helpers: fix naming and values

Author: jcarpent

include/proxsuite/helpers/common.hpp

@@ -35,14 +35,14 @@ struct infinite_bound
 /// @brief \brief Returns the part of the expression which is lower than value
 template<typename T, typename Scalar>
 auto
-lower_than(T const& expr, const Scalar value) PROXSUITE_DEDUCE_RET(
-  (expr.array() < value).select(expr, T::Zero(expr.rows())));
+at_most(T const& expr, const Scalar value) PROXSUITE_DEDUCE_RET(
+  (expr.array() < value).select(expr, T::Constant(expr.rows(), value)));
 
 /// @brief \brief Returns the part of the expression which is greater than value
 template<typename T, typename Scalar>
 auto
-greater_than(T const& expr, const Scalar value) PROXSUITE_DEDUCE_RET(
-  (expr.array() > value).select(expr, T::Zero(expr.rows())));
+at_least(T const& expr, const Scalar value) PROXSUITE_DEDUCE_RET(
+  (expr.array() > value).select(expr, T::Constant(expr.rows(), value)));
 
 /// @brief \brief Returns the positive part of an expression
 template<typename T>

include/proxsuite/proxqp/dense/utils.hpp

@@ -398,13 +398,13 @@ global_dual_residual(Results<T>& qpresults,
 
   const T zu =
     helpers::positive_part(qpresults.z)
-      .dot(helpers::lower_than(qpmodel.u, helpers::infinite_bound<T>::value()));
+      .dot(helpers::at_most(qpmodel.u, helpers::infinite_bound<T>::value()));
   rhs_duality_gap = std::max(rhs_duality_gap, std::abs(zu));
   duality_gap += zu;
 
-  const T zl = helpers::negative_part(qpresults.z)
-                 .dot(helpers::greater_than(
-                   qpmodel.l, -helpers::infinite_bound<T>::value()));
+  const T zl =
+    helpers::negative_part(qpresults.z)
+      .dot(helpers::at_least(qpmodel.l, -helpers::infinite_bound<T>::value()));
   rhs_duality_gap = std::max(rhs_duality_gap, std::abs(zl));
   duality_gap += zl;
 

include/proxsuite/proxqp/sparse/utils.hpp

@@ -667,12 +667,12 @@ unscaled_primal_dual_residual(
     precond.unscale_dual_in_place_in({ proxsuite::proxqp::from_eigen, z_e });
 
     const T zl = helpers::negative_part(z_e).dot(
-      helpers::greater_than(data.l, -helpers::infinite_bound<T>::value()));
+      helpers::at_least(data.l, -helpers::infinite_bound<T>::value()));
     results.info.duality_gap += zl;
     rhs_duality_gap = std::max(rhs_duality_gap, std::abs(zl));
 
     const T zu = helpers::positive_part(z_e).dot(
-      helpers::lower_than(data.u, helpers::infinite_bound<T>::value()));
+      helpers::at_most(data.u, helpers::infinite_bound<T>::value()));
     results.info.duality_gap += zu;
     rhs_duality_gap = std::max(rhs_duality_gap, std::abs(zu));