Skip to content

Conversation

@edantec
Copy link
Collaborator

@edantec edantec commented Feb 6, 2025

No description provided.

@edantec edantec requested a review from EtienneAr February 6, 2025 16:16
Copy link
Collaborator

@EtienneAr EtienneAr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @edantec!

@edantec
Copy link
Collaborator Author

edantec commented Feb 12, 2025

All fixes done, let me know what you think

@edantec
Copy link
Collaborator Author

edantec commented Feb 12, 2025

I've fixed the python example and the friction test. We should be good now.

@edantec
Copy link
Collaborator Author

edantec commented Feb 13, 2025

I have added back the throw exception because assert didn't warn us if the vectors have the right size (and this is dangerous).

@edantec
Copy link
Collaborator Author

edantec commented Feb 14, 2025

computeFriction now uses a proxy in python bindings. Note that in Python the torque vector provided in argument is still modified (so it is equal to the returned torque).

@EtienneAr EtienneAr merged commit d7b4950 into main Feb 17, 2025
11 checks passed
@edantec edantec deleted the topic/friction branch February 17, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants