this shit is so code

Author: DEATHB4DEFEAT

.vscode/launch.json

@@ -3,6 +3,7 @@
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=OS/@EntryIndexedValue">OS</s:String>
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=VM/@EntryIndexedValue">VM</s:String>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=Avalonia/@EntryIndexedValue">True</s:Boolean>
+	<s:Boolean x:Key="/Default/UserDictionary/Words/=byond/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=prerelease/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=ROWID/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=zeroblob/@EntryIndexedValue">True</s:Boolean></wpf:ResourceDictionary>

SS14.Launcher.sln.DotSettings

@@ -234,8 +234,10 @@ region-short-south-america-west = SA West
 ## Strings for the "servers" tab
 
 tab-servers-title = Servers
-tab-servers-classic-title = Classic Servers
-tab-servers-classic-desc = All servers listed here connect via the BYOND client.
+tab-servers-byond-title = BYOND Servers
+tab-servers-byond-error-msg = BYOND not installed or found
+tab-servers-byond-error-desc = To connect to BYOND servers, please install BYOND from https://www.byond.com/download/ and ensure it is set as the default program for handling byond:// links.
+tab-servers-byond-error-link-text = Download BYOND
 tab-servers-refresh = Refresh
 filters = Filters ({ $filteredServers } / { $totalServers })
 tab-servers-search-watermark = Search For Servers…

SS14.Launcher/Assets/Locale/en-US/text.ftl

@@ -29,8 +29,6 @@ public async Task Refresh()
         try
         {
             var response = await _http.GetStringAsync("http://www.byond.com/games/exadv1/spacestation13?format=text");
-            // Log.Information("BYOND Response: {Response}", response);
-            await File.WriteAllTextAsync("byond_dump.txt", response);
             var servers = ParseByondResponse(response);
 
             Avalonia.Threading.Dispatcher.UIThread.Post(() =>
@@ -79,7 +77,7 @@ private List<ClassicServerStatusData> ParseByondResponse(string response)
                     var roundTime = ExtractRoundTimeFromStatus(currentStatus);
                     list.Add(new ClassicServerStatusData(name, currentUrl, currentPlayers, CleanStatus(currentStatus, name) ?? "", roundTime ?? "In-Lobby"));
                 }
-                
+
                 // Reset for new server
                 inServerBlock = true;
                 currentName = null;
@@ -149,7 +147,7 @@ private List<ClassicServerStatusData> ParseByondResponse(string response)
     private string? ExtractRoundTimeFromStatus(string? status)
     {
         if (string.IsNullOrEmpty(status)) return null;
-        
+
         // Try to match "Round time: <b>00:07</b>" or similar
         var match = System.Text.RegularExpressions.Regex.Match(status, @"Round\s+time:\s+(?:<b>)?(\d{1,2}:\d{2})(?:</b>)?", System.Text.RegularExpressions.RegexOptions.IgnoreCase);
         if (match.Success)
@@ -171,20 +169,20 @@ private List<ClassicServerStatusData> ParseByondResponse(string response)
              var clean = System.Text.RegularExpressions.Regex.Replace(raw, "<.*?>", String.Empty);
              return System.Net.WebUtility.HtmlDecode(clean);
         }
-        return null; 
+        return null;
     }
 
     private string? CleanStatus(string? status, string? nameToRemove)
     {
         if (string.IsNullOrEmpty(status)) return null;
-        
+
         var s = status.Replace("<br>", "\n").Replace("<br/>", "\n").Replace("<br />", "\n");
         // Remove tags
         s = System.Text.RegularExpressions.Regex.Replace(s, "<.*?>", String.Empty);
-        
+
         // Decode HTML
         s = System.Net.WebUtility.HtmlDecode(s);
-        
+
         if (nameToRemove != null && s.StartsWith(nameToRemove))
         {
             s = s.Substring(nameToRemove.Length);
@@ -211,13 +209,13 @@ private string ParseStringValue(string line)
 
         // Extract content inside quotes
         var inner = line.Substring(idx + 1, lastIdx - idx - 1);
-        
+
         // Unescape BYOND/C string escapes
         // \" -> "
         // \n -> newline
         // \\ -> \
         // The most critical one is \n showing up as literal \n in UI.
-        
+
         // Simple manual unescape for common sequences
         return inner.Replace("\\\"", "\"")
                     .Replace("\\n", "\n")

SS14.Launcher/Models/ServerStatus/ClassicServerListCache.cs

@@ -1,21 +1,10 @@
-using System.Collections.Generic;
-
 namespace SS14.Launcher.Models.ServerStatus;
 
-public class ClassicServerStatusData
+public class ClassicServerStatusData(string name, string address, int playerCount, string status, string roundTime)
 {
-    public string Name { get; set; } = string.Empty;
-    public string Address { get; set; } = string.Empty;
-    public int PlayerCount { get; set; }
-    public string Status { get; set; } = string.Empty;
-    public string RoundTime { get; set; } = string.Empty;
-
-    public ClassicServerStatusData(string name, string address, int playerCount, string status, string roundTime)
-    {
-        Name = name;
-        Address = address;
-        PlayerCount = playerCount;
-        Status = status;
-        RoundTime = roundTime;
-    }
+    public string Name { get; } = name;
+    public string Address { get; } = address;
+    public int PlayerCount { get; } = playerCount;
+    public string Status { get; } = status;
+    public string RoundTime { get; } = roundTime;
 }

SS14.Launcher/Models/ServerStatus/ClassicServerStatusData.cs

@@ -1,16 +1,18 @@
 using System;
 using System.Diagnostics;
-using Microsoft.Win32;
 using ReactiveUI;
-using SS14.Launcher;
+using Serilog;
+using Splat;
 using SS14.Launcher.Localization;
+using SS14.Launcher.Models;
 using SS14.Launcher.Models.ServerStatus;
-using SS14.Launcher.ViewModels;
+using SS14.Launcher.Utility;
 
 namespace SS14.Launcher.ViewModels.MainWindowTabs;
 
 public class ClassicServerEntryViewModel : ViewModelBase
 {
+    private readonly MainWindowViewModel _mainWindow;
     private readonly ClassicServerStatusData _server;
 
     public string Name => _server.Name;
@@ -20,6 +22,7 @@ public class ClassicServerEntryViewModel : ViewModelBase
     public string RoundTime => _server.RoundTime;
 
     private bool _isExpanded;
+
     public bool IsExpanded
     {
         get => _isExpanded;
@@ -28,8 +31,9 @@ public bool IsExpanded
 
     public ReactiveCommand<System.Reactive.Unit, System.Reactive.Unit> ConnectCommand { get; }
 
-    public ClassicServerEntryViewModel(ClassicServerStatusData server)
+    public ClassicServerEntryViewModel(MainWindowViewModel mainWindow, ClassicServerStatusData server)
     {
+        _mainWindow = mainWindow;
         _server = server;
 
         ConnectCommand = ReactiveCommand.Create(Connect);
@@ -38,61 +42,47 @@ public ClassicServerEntryViewModel(ClassicServerStatusData server)
     private void Connect()
     {
         if (IsByondInstalled())
-        {
-            Helpers.OpenUri(new Uri(_server.Address));
-        }
+            Helpers.OpenUri(new Uri(Address));
         else
         {
-            // Prompt to download
-            // We can use the native MessageBox helper from Helpers if available or just open the link.
-            // Following the prompt instructions mostly literally: "prompted to install it first by going to this link"
-            
-            // On Windows we can use the MessageBox to be nicer. 
-            // NOTE: Helper MessageBox returns int, 1 is usually OK.
-            if (OperatingSystem.IsWindows())
+            Log.Information("User attempted to connect to BYOND server but BYOND is not installed.");
+            // Set the MainWindowViewModel's CustomInfo to show the BYOND not installed message
+            // I didn't wanna make another dialog, reuse the generic thing :)
+            _mainWindow.CustomInfo = new LauncherInfoManager.CustomInfo()
             {
-                var res = Helpers.MessageBoxHelper(
-                    "BYOND not detected. You need the BYOND client to play Space Station 13. Go to download page?", 
-                    "BYOND Missing", 
-                    0x00000004 | 0x00000030); // MB_YESNO | MB_ICONWARNING
-                
-                if (res == 6) // IDYES
-                {
-                     Helpers.OpenUri(new Uri("https://www.byond.com/download/"));
-                }
-            }
-            else
-            {
-                // Non-windows, just open the link? Or maybe they have it via Wine?
-                // For now, let's open the link if we can't be sure, or maybe just try launching it?
-                // The prompt was "Check if they have BYOND... If not... prompt".
-                // Since I can't check on Linux easily, I'll assume they might not have it if I can't check.
-                // But actually, opening the URI is the best 'try'.
-                // Let's just try to open it on non-windows.
-                 Helpers.OpenUri(new Uri(_server.Address));
-            }
+                Message = LocalizationManager.Instance.GetString("tab-servers-byond-error-msg"),
+                Description = LocalizationManager.Instance.GetString("tab-servers-byond-error-desc"),
+                LinkText = LocalizationManager.Instance.GetString("tab-servers-byond-error-link-text"),
+                Link = "https://www.byond.com/download/",
+            };
         }
     }
 
     private bool IsByondInstalled()
     {
-        if (!OperatingSystem.IsWindows())
+        #if WINDOWS
+        using var key = Registry.CurrentUser.OpenSubKey(@"Software\Dantom\BYOND");
+        return key != null;
+        #elif LINUX
+        // Ask xdg-mime if BYOND is registered
+        var process = new Process
         {
-            // On Linux/Mac, we can't easily check for BYOND (usually running under Wine).
-            // We'll return true to let the OS/Wine try to handle the protocol.
-            return true;
-        }
+            StartInfo = new ProcessStartInfo
+            {
+                FileName = "xdg-mime",
+                Arguments = "query default x-scheme-handler/byond",
+                RedirectStandardOutput = true,
+                UseShellExecute = false,
+                CreateNoWindow = true,
+            },
+        };
+        process.Start();
+        var output = process.StandardOutput.ReadToEnd();
+        process.WaitForExit();
 
-        try
-        {
-            // Check for BYOND in Registry
-            // HKCU\Software\Dantom\BYOND is the standard key.
-            using var key = Registry.CurrentUser.OpenSubKey(@"Software\Dantom\BYOND");
-            return key != null;
-        }
-        catch
-        {
-            return false;
-        }
+        return !string.IsNullOrWhiteSpace(output);
+        #elif MACOS
+        return true; // No idea, they might have it, might not
+        #endif
     }
 }

SS14.Launcher/ViewModels/MainWindowTabs/ClassicServerEntryViewModel.cs

@@ -11,11 +11,12 @@ namespace SS14.Launcher.ViewModels.MainWindowTabs;
 
 public class ClassicServerListTabViewModel : MainWindowTabViewModel
 {
+    private readonly MainWindowViewModel _mainWindow;
     private readonly ClassicServerListCache _cache;
 
     private readonly LocalizationManager _loc = LocalizationManager.Instance;
 
-    public override string Name => _loc.GetString("tab-servers-classic-title"); 
+    public override string Name => _loc.GetString("tab-servers-byond-title");
 
     private string? _searchString;
 
@@ -32,11 +33,12 @@ public string? SearchString
     public ObservableCollection<ClassicServerEntryViewModel> AllServers { get; } = new();
     public ReactiveCommand<System.Reactive.Unit, System.Reactive.Unit> RefreshPressed { get; }
 
-    public ClassicServerListTabViewModel()
+    public ClassicServerListTabViewModel(MainWindowViewModel mainWindow)
     {
+        _mainWindow = mainWindow;
         _cache = Locator.Current.GetRequiredService<ClassicServerListCache>();
         RefreshPressed = ReactiveCommand.CreateFromTask(_cache.Refresh);
-        
+
         // Initial populate if any
         UpdateList();
 
@@ -54,18 +56,18 @@ private void UpdateList()
         // Filter then Sort by Players descending
         var filtered = _cache.AllServers.Where(DoesSearchMatch);
         var sorted = filtered.OrderByDescending(s => s.PlayerCount).ToList();
-        
+
         foreach (var s in sorted)
         {
-            AllServers.Add(new ClassicServerEntryViewModel(s));
+            AllServers.Add(new ClassicServerEntryViewModel(_mainWindow, s));
         }
     }
 
     private bool DoesSearchMatch(ClassicServerStatusData data)
     {
         if (string.IsNullOrWhiteSpace(_searchString))
             return true;
-        
+
         return data.Name.Contains(_searchString, System.StringComparison.CurrentCultureIgnoreCase);
     }
 

SS14.Launcher/ViewModels/MainWindowTabs/ClassicServerListTabViewModel.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Linq;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.Diagnostics.CodeAnalysis;

SS14.Launcher/ViewModels/MainWindowTabs/HomePageViewModel.cs

@@ -3,7 +3,6 @@
 using System.Linq;
 using Avalonia.Controls;
 using Avalonia.VisualTree;
-using DynamicData;
 using Microsoft.Toolkit.Mvvm.ComponentModel;
 using Microsoft.Toolkit.Mvvm.Messaging;
 using SS14.Launcher.Api;

SS14.Launcher/ViewModels/MainWindowTabs/ServerEntryViewModel.cs

@@ -52,7 +52,7 @@ public MainWindowViewModel()
         _loc = LocalizationManager.Instance;
 
         ServersTab = new ServerListTabViewModel(this);
-        ClassicServersTab = new ClassicServerListTabViewModel();
+        ClassicServersTab = new ClassicServerListTabViewModel(this);
         NewsTab = new NewsTabViewModel();
         HomeTab = new HomePageViewModel(this);
         OptionsTab = new OptionsTabViewModel();