Skip to content

Commit a5a38fc

Browse files
committed
Limit console handler
Logging needs a console handler when set to INFO or DEBUG. That way INFO and DEBUG messages get sent to the console. Not needed for WARNING or ERROR levels.
1 parent 69ee734 commit a5a38fc

File tree

1 file changed

+15
-11
lines changed

1 file changed

+15
-11
lines changed

comment_spell_check/comment_spell_check.py

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -505,6 +505,7 @@ def setup_logger(args):
505505
level = logging.INFO
506506
if args.verbose:
507507
level = logging.DEBUG
508+
print("Verbose mode enabled")
508509
if args.miss:
509510
level = logging.ERROR
510511
if args.brief:
@@ -513,20 +514,23 @@ def setup_logger(args):
513514
logger = logging.getLogger("comment_spell_check")
514515
logger.setLevel(level)
515516

516-
# Create a console handler
517-
ch = logging.StreamHandler()
518-
ch.setLevel(level)
517+
if level in (logging.INFO, logging.DEBUG):
518+
# info and debug messages will be printed to the console
519519

520-
# Create a formatter
521-
formatter = logging.Formatter(
522-
"%(asctime)s - %(name)s - %(levelname)s - %(message)s"
523-
)
520+
# Create a console handler
521+
ch = logging.StreamHandler()
522+
ch.setLevel(level)
523+
524+
# Create a formatter
525+
formatter = logging.Formatter(
526+
"%(asctime)s - %(name)s - %(levelname)s - %(message)s"
527+
)
524528

525-
# Add formatter to ch
526-
ch.setFormatter(formatter)
529+
# Add formatter to ch
530+
ch.setFormatter(formatter)
527531

528-
# Add ch to logger
529-
logger.addHandler(ch)
532+
# Add ch to logger
533+
logger.addHandler(ch)
530534

531535
return logger
532536

0 commit comments

Comments
 (0)