[2.1|3.0] Bug in code

[woodholly]

Description

Here: https://github.com/SimpleMachines/SMF/blob/release-2.1/Sources/Subs-Editor.php#L920

[DiegoAndresCortes]

What would be the bug?

[bhsmither]

The line

$tag_type == 'iurl';

uses loose comparison equality operator.

I am not aware that the result of this comparison (true-like) could possibly be assigned to the variable.

I believe the intent is to assign the string to the variable. Thus,

$tag_type = 'iurl';

would be the correct statement.

[DiegoAndresCortes]

Ah I see it now, fair enough.

[Sesquipedalian]

I think the logic for that is also reversed. If the HTML is <a href="http://example.com" target="_blank"> then we want the [url] BBC, not the [iurl] BBC. Or to say the same thing in a different way, we should use [iurl] unless target="_blank" exists.

So this line

SMF/Sources/Subs-Editor.php

Line 883 in 2341c94

$tag_type = 'url';

should be changed to

$tag_type = 'iurl';

... whereas this line

SMF/Sources/Subs-Editor.php

Line 920 in 2341c94

$tag_type == 'iurl';

should be changed to

$tag_type = 'url';

[Sesquipedalian]

Any updates on this, @jdarwood007? Since you self-assigned this, I don't want to step on your toes by doing it myself.

[jdarwood007]

I haven't had a chance to send a PR. Its a simple fix. The same code is in 3.0