[3.0/2.1]: Installing packages/themes does not parse line breaks for the XML tags.

[DiegoAndresCortes]

Basic Information

On a side note, I noticed that the XML parser for package-info.xml is broken and does not support line breaks within elements. This behavior cost me over an hour, as I didn't suspect this to be an issue. ;) It would be good to at least have this documented somewhere.

For example, this works:

<install for="2.1.4-2.1.99">
    <readme type="file" parsebbc="true">readme.txt</readme>
    <require-file name="obdaSameWindowLinks.php" destination="$sourcedir" />
    <hook hook="integrate_post_parsebbc" function="obdaSameWindowLinksReplaceTargetBlank" file="$sourcedir/obdaSameWindowLinks.php" />
    <hook hook="integrate_credits" function="obdaSameWindowLinksCredits" file="$sourcedir/obdaSameWindowLinks.php" />
</install>
<uninstall for="2.1.4-2.1.99">
    <hook hook="integrate_post_parsebbc" function="obdaSameWindowLinksReplaceTargetBlank" file="$sourcedir/obdaSameWindowLinks.php" reverse="true" />
    <hook hook="integrate_credits" function="obdaSameWindowLinksCredits" file="$sourcedir/obdaSameWindowLinks.php" reverse="true" />
    <remove-file name="$sourcedir/obdaSameWindowLinks.php" />
</uninstall>

On the other hand, this valid XML will cause the package installer to report that the package is broken:

<install for="2.1.4-2.1.99">
    <readme type="file" parsebbc="true">readme.txt</readme>
    <require-file name="obdaSameWindowLinks.php"
                  destination="$sourcedir" />
    <hook hook="integrate_post_parsebbc"
          function="obdaSameWindowLinksReplaceTargetBlank"
          file="$sourcedir/obdaSameWindowLinks.php" />
    <hook hook="integrate_credits"
          function="obdaSameWindowLinksCredits"
          file="$sourcedir/obdaSameWindowLinks.php" />
</install>
<uninstall for="2.1.4-2.1.99">
    <hook hook="integrate_post_parsebbc"
          function="obdaSameWindowLinksReplaceTargetBlank"
          file="$sourcedir/obdaSameWindowLinks.php"
          reverse="true" />
    <hook hook="integrate_credits"
          function="obdaSameWindowLinksCredits"
          file="$sourcedir/obdaSameWindowLinks.php"
          reverse="true" />
    <remove-file name="$sourcedir/obdaSameWindowLinks.php" />
</uninstall>

[MissAllSunday]

I can confirm this, left a simple PR to resolve it.

[MissAllSunday]

mmm #8237 references this issue and marks it as solved , I suppose I don't have enough permissions to do so anymore, anyway, this should be closed unless it also happens on 3.0 but last time I checked 3.0 it handles parsing differently.