Skip to content

Commit 14478e7

Browse files
committed
fix #335, add a menu item for calling unknown numbers from Recents
1 parent 0cf7bac commit 14478e7

File tree

16 files changed

+28
-11
lines changed

16 files changed

+28
-11
lines changed

app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ android {
5151
}
5252

5353
dependencies {
54-
implementation 'com.simplemobiletools:commons:5.6.1'
54+
implementation 'com.simplemobiletools:commons:5.6.2'
5555
implementation 'joda-time:joda-time:2.10.1'
5656
implementation 'androidx.constraintlayout:constraintlayout:2.0.0-alpha3'
5757
implementation 'com.googlecode.ez-vcard:ez-vcard:0.10.4'

app/src/main/kotlin/com/simplemobiletools/contacts/pro/activities/DialpadActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class DialpadActivity : SimpleActivity() {
5555
ContactsHelper(this).getContacts { gotContacts(it) }
5656
disableKeyboardPopping()
5757

58-
val callIcon = resources.getColoredDrawableWithColor(R.drawable.ic_phone_big, if (isBlackAndWhiteTheme()) Color.BLACK else Color.WHITE)
58+
val callIcon = resources.getColoredDrawableWithColor(R.drawable.ic_phone_huge, if (isBlackAndWhiteTheme()) Color.BLACK else Color.WHITE)
5959
dialpad_call_button.setImageDrawable(callIcon)
6060
dialpad_call_button.background.applyColorFilter(getAdjustedPrimaryColor())
6161
}

app/src/main/kotlin/com/simplemobiletools/contacts/pro/adapters/RecentCallsAdapter.kt

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import com.simplemobiletools.contacts.pro.R
1313
import com.simplemobiletools.contacts.pro.activities.SimpleActivity
1414
import com.simplemobiletools.contacts.pro.extensions.addBlockedNumber
1515
import com.simplemobiletools.contacts.pro.extensions.config
16+
import com.simplemobiletools.contacts.pro.extensions.startCallIntent
1617
import com.simplemobiletools.contacts.pro.helpers.ContactsHelper
1718
import com.simplemobiletools.contacts.pro.helpers.RECENTS_TAB_MASK
1819
import com.simplemobiletools.contacts.pro.interfaces.RefreshContactsListener
@@ -31,9 +32,15 @@ class RecentCallsAdapter(activity: SimpleActivity, var recentCalls: ArrayList<Re
3132
override fun getActionMenuId() = R.menu.cab_recent_calls
3233

3334
override fun prepareActionMode(menu: Menu) {
35+
val selectedItems = getSelectedItems()
36+
if (selectedItems.isEmpty()) {
37+
return
38+
}
39+
3440
menu.apply {
3541
findItem(R.id.cab_block_number).isVisible = isNougatPlus()
3642
findItem(R.id.cab_block_number).title = activity.getString(if (isOneItemSelected()) R.string.block_number else R.string.block_numbers)
43+
findItem(R.id.cab_call_number).isVisible = isOneItemSelected() && selectedItems.first().name == null
3744
}
3845
}
3946

@@ -43,6 +50,7 @@ class RecentCallsAdapter(activity: SimpleActivity, var recentCalls: ArrayList<Re
4350
}
4451

4552
when (id) {
53+
R.id.cab_call_number -> callNumber()
4654
R.id.cab_select_all -> selectAll()
4755
R.id.cab_delete -> askConfirmDelete()
4856
R.id.cab_block_number -> blockNumber()
@@ -76,6 +84,10 @@ class RecentCallsAdapter(activity: SimpleActivity, var recentCalls: ArrayList<Re
7684
fastScroller?.measureRecyclerView()
7785
}
7886

87+
private fun callNumber() {
88+
(activity as SimpleActivity).startCallIntent(getSelectedItems().first().number)
89+
}
90+
7991
private fun askConfirmDelete() {
8092
ConfirmationDialog(activity) {
8193
deleteRecentCalls()
316 Bytes
Loading
406 Bytes
Loading
566 Bytes
Loading
716 Bytes
Loading

0 commit comments

Comments
 (0)