Merge pull request #730 from Aga-C/prevent-adding-empty-contact

Prevented adding empty contact (#728)

Author: tibbi

app/src/main/kotlin/com/simplemobiletools/contacts/pro/activities/EditContactActivity.kt

@@ -907,6 +907,31 @@ class EditContactActivity : ContactActivity() {
             return
         }
 
+        val filledPhoneNumbers = getFilledPhoneNumbers()
+        val filledEmails = getFilledEmails()
+        val filledAddresses = getFilledAddresses()
+        val filledIMs = getFilledIMs()
+        val filledEvents = getFilledEvents()
+        val filledWebsites = getFilledWebsites()
+
+        val contactFields = arrayListOf(
+            contact_prefix, contact_first_name, contact_middle_name, contact_surname, contact_suffix, contact_nickname,
+            contact_notes, contact_organization_company, contact_organization_job_position
+        )
+
+        if (contactFields.all { it.value.isEmpty() } &&
+            currentContactPhotoPath.isEmpty() &&
+            filledPhoneNumbers.isEmpty() &&
+            filledEmails.isEmpty() &&
+            filledAddresses.isEmpty() &&
+            filledIMs.isEmpty() &&
+            filledEvents.isEmpty() &&
+            filledWebsites.isEmpty()
+        ) {
+            toast(R.string.fields_empty)
+            return
+        }
+
         contact?.apply {
             val oldPhotoUri = photoUri
 
@@ -917,14 +942,14 @@ class EditContactActivity : ContactActivity() {
             suffix = contact_suffix.value
             nickname = contact_nickname.value
             photoUri = currentContactPhotoPath
-            phoneNumbers = getFilledPhoneNumbers()
-            emails = getFilledEmails()
-            addresses = getFilledAddresses()
-            IMs = getFilledIMs()
-            events = getFilledEvents()
+            phoneNumbers = filledPhoneNumbers
+            emails = filledEmails
+            addresses = filledAddresses
+            IMs = filledIMs
+            events = filledEvents
             starred = if (isContactStarred()) 1 else 0
             notes = contact_notes.value
-            websites = getFilledWebsites()
+            websites = filledWebsites
 
             val company = contact_organization_company.value
             val jobPosition = contact_organization_job_position.value

app/src/main/res/values-ar/strings.xml

@@ -14,6 +14,7 @@
     <string name="send_email_to_group">ارسال بريد الكتروني الى مجموعة</string>
     <string name="create_new_contact">إنشاء جهة إتصال</string>
     <string name="add_to_existing_contact">إضافة إلى جهة موجودة</string>
+    <string name="fields_empty">At least 1 field has to be filled out</string>
 
     <!-- Placeholders -->
     <string name="no_contacts_with_emails">لا توجد جهات اتصال بهذا البريد الالكتروني</string>

app/src/main/res/values-az/strings.xml

@@ -14,6 +14,7 @@
     <string name="send_email_to_group">Grupa e-poçt göndər</string>
     <string name="create_new_contact">Create new contact</string>
     <string name="add_to_existing_contact">Add to an existing contact</string>
+    <string name="fields_empty">At least 1 field has to be filled out</string>
 
     <!-- Placeholders -->
     <string name="no_contacts_with_emails">No contacts with emails have been found</string>

app/src/main/res/values-cs/strings.xml

@@ -14,6 +14,7 @@
     <string name="send_email_to_group">Poslat skupině e-mail</string>
     <string name="create_new_contact">Vytvořit nový kontakt</string>
     <string name="add_to_existing_contact">Přidat k existujícímu kontaktu</string>
+    <string name="fields_empty">At least 1 field has to be filled out</string>
 
     <!-- Placeholders -->
     <string name="no_contacts_with_emails">Nenalezeny žádné kontakty s e-maily</string>

app/src/main/res/values-cy/strings.xml

@@ -14,6 +14,7 @@
     <string name="send_email_to_group">Anfon ebost at grŵp</string>
     <string name="create_new_contact">Creu cyswllt newydd</string>
     <string name="add_to_existing_contact">Ychwanegu at gyswllt sy\'n bodoli</string>
+    <string name="fields_empty">At least 1 field has to be filled out</string>
 
     <!-- Placeholders -->
     <string name="no_contacts_with_emails">Ni chanfuwyd unrhyw gysylltiadau gydag ebost</string>

app/src/main/res/values-da/strings.xml

@@ -15,6 +15,7 @@
     <string name="send_email_to_group">Send e-mail til gruppe</string>
     <string name="create_new_contact">Opret ny kontakt</string>
     <string name="add_to_existing_contact">Tilføj til en eksisterende kontakt</string>
+    <string name="fields_empty">At least 1 field has to be filled out</string>
     <!-- Placeholders -->
     <string name="no_contacts_with_emails">Ingen kontakter med e-mails fundet</string>
     <string name="no_contacts_with_phone_numbers">Ingen kontakter med telefonnumre fundet</string>

app/src/main/res/values-de/strings.xml

@@ -15,6 +15,7 @@
     <string name="send_email_to_group">E-Mail an Gruppe senden</string>
     <string name="create_new_contact">Neuen Kontakt erstellen</string>
     <string name="add_to_existing_contact">Zu einem existierenden Kontakt hinzufügen</string>
+    <string name="fields_empty">At least 1 field has to be filled out</string>
     <!-- Placeholders -->
     <string name="no_contacts_with_emails">Keine Kontakte mit E-Mailadressen gefunden</string>
     <string name="no_contacts_with_phone_numbers">Keine Kontakte mit Telefonnummern gefunden</string>

app/src/main/res/values-el/strings.xml

@@ -14,6 +14,7 @@
     <string name="send_email_to_group">Αποστολή email σε ομάδες</string>
     <string name="create_new_contact">Δημιουργία νέας Επαφής</string>
     <string name="add_to_existing_contact">Προσθήκη σε μια υπάρχουσα Επαφή</string>
+    <string name="fields_empty">At least 1 field has to be filled out</string>
 
     <!-- Placeholders -->
     <string name="no_contacts_with_emails">Δεν βρέθηκαν Επαφές με emails</string>

app/src/main/res/values-es/strings.xml

@@ -14,6 +14,7 @@
     <string name="send_email_to_group">Enviar correo electrónico a grupo</string>
     <string name="create_new_contact">Crear nuevo contacto</string>
     <string name="add_to_existing_contact">Añadir a un contacto existente</string>
+    <string name="fields_empty">At least 1 field has to be filled out</string>
 
     <!-- Placeholders -->
     <string name="no_contacts_with_emails">No se encontraron contactos con correo electrónico</string>

app/src/main/res/values-eu/strings.xml

@@ -14,6 +14,7 @@
     <string name="send_email_to_group">Bidali emaila taldeari</string>
     <string name="create_new_contact">Create new contact</string>
     <string name="add_to_existing_contact">Add to an existing contact</string>
+    <string name="fields_empty">At least 1 field has to be filled out</string>
 
     <!-- Placeholders -->
     <string name="no_contacts_with_emails">No contacts with emails have been found</string>