Skip to content

Commit 2b636f7

Browse files
committed
fix some crashes at inflating some views
1 parent 013bb71 commit 2b636f7

File tree

1 file changed

+18
-22
lines changed

1 file changed

+18
-22
lines changed

app/src/main/kotlin/com/simplemobiletools/contacts/activities/ContactActivity.kt

Lines changed: 18 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ import com.simplemobiletools.contacts.models.Email
4040
import com.simplemobiletools.contacts.models.Event
4141
import com.simplemobiletools.contacts.models.PhoneNumber
4242
import kotlinx.android.synthetic.main.activity_contact.*
43-
import kotlinx.android.synthetic.main.activity_contact.view.*
4443
import kotlinx.android.synthetic.main.item_email.view.*
4544
import kotlinx.android.synthetic.main.item_event.view.*
4645
import kotlinx.android.synthetic.main.item_phone_number.view.*
@@ -609,35 +608,32 @@ class ContactActivity : SimpleActivity() {
609608
}
610609

611610
private fun addNewPhoneNumberField() {
612-
layoutInflater.inflate(R.layout.item_phone_number, contact_numbers_holder, false).apply {
613-
updateTextColors(this as ViewGroup)
614-
setupPhoneNumberTypePicker(contact_number_type)
615-
contact_numbers_holder.addView(this)
616-
contact_numbers_holder.onGlobalLayout {
617-
contact_number.requestFocus()
618-
showKeyboard(contact_number)
619-
}
611+
val numberHolder = layoutInflater.inflate(R.layout.item_phone_number, contact_numbers_holder, false) as ViewGroup
612+
updateTextColors(numberHolder)
613+
setupPhoneNumberTypePicker(numberHolder.contact_number_type)
614+
contact_numbers_holder.addView(numberHolder)
615+
contact_numbers_holder.onGlobalLayout {
616+
numberHolder.contact_number.requestFocus()
617+
showKeyboard(numberHolder.contact_number)
620618
}
621619
}
622620

623621
private fun addNewEmailField() {
624-
layoutInflater.inflate(R.layout.item_email, contact_emails_holder, false).apply {
625-
updateTextColors(this as ViewGroup)
626-
setupEmailTypePicker(contact_email_type)
627-
contact_emails_holder.addView(this)
628-
contact_emails_holder.onGlobalLayout {
629-
contact_email.requestFocus()
630-
showKeyboard(contact_email)
631-
}
622+
val emailHolder = layoutInflater.inflate(R.layout.item_email, contact_emails_holder, false) as ViewGroup
623+
updateTextColors(emailHolder)
624+
setupEmailTypePicker(emailHolder.contact_email_type)
625+
contact_emails_holder.addView(emailHolder)
626+
contact_emails_holder.onGlobalLayout {
627+
emailHolder.contact_email.requestFocus()
628+
showKeyboard(emailHolder.contact_email)
632629
}
633630
}
634631

635632
private fun addNewEventField() {
636-
layoutInflater.inflate(R.layout.item_event, contact_events_holder, false).apply {
637-
updateTextColors(this as ViewGroup)
638-
setupEventTypePicker(this)
639-
contact_events_holder.addView(this)
640-
}
633+
val eventHolder = layoutInflater.inflate(R.layout.item_event, contact_events_holder, false) as ViewGroup
634+
updateTextColors(eventHolder)
635+
setupEventTypePicker(eventHolder)
636+
contact_events_holder.addView(eventHolder)
641637
}
642638

643639
private fun deleteContact() {

0 commit comments

Comments
 (0)