Skip to content

Commit 85fa2fc

Browse files
authored
Merge pull request #953 from Mylloon/fix/GH-952
Use PREF for the preference rather than the number type
2 parents 241a7a9 + 3ae9bc2 commit 85fa2fc

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

app/src/main/kotlin/com/simplemobiletools/contacts/pro/helpers/VcfExporter.kt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,9 @@ class VcfExporter {
7373
contact.phoneNumbers.forEach {
7474
val phoneNumber = Telephone(it.value)
7575
phoneNumber.parameters.addType(getPhoneNumberTypeLabel(it.type, it.label))
76+
if (it.isPrimary) {
77+
phoneNumber.parameters.addType(getPreferredType(1))
78+
}
7679
card.addTelephoneNumber(phoneNumber)
7780
}
7881

@@ -201,4 +204,6 @@ class VcfExporter {
201204
StructuredPostal.TYPE_OTHER -> OTHER
202205
else -> label
203206
}
207+
208+
private fun getPreferredType(value: Int) = "$PREF=$value"
204209
}

app/src/main/kotlin/com/simplemobiletools/contacts/pro/helpers/VcfImporter.kt

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,9 @@ class VcfImporter(val activity: SimpleActivity) {
6464
} else {
6565
""
6666
}
67+
val preferred = getPreferredValue(it.types.lastOrNull()?.value) == 1
6768

68-
phoneNumbers.add(PhoneNumber(number, type, label, number.normalizePhoneNumber()))
69+
phoneNumbers.add(PhoneNumber(number, type, label, number.normalizePhoneNumber(), preferred))
6970
}
7071

7172
val emails = ArrayList<Email>()
@@ -267,7 +268,7 @@ class VcfImporter(val activity: SimpleActivity) {
267268
Phone.TYPE_WORK
268269
}
269270
}
270-
PREF, MAIN -> Phone.TYPE_MAIN
271+
MAIN -> Phone.TYPE_MAIN
271272
WORK_FAX -> Phone.TYPE_FAX_WORK
272273
HOME_FAX -> Phone.TYPE_FAX_HOME
273274
FAX -> Phone.TYPE_FAX_WORK
@@ -308,4 +309,14 @@ class VcfImporter(val activity: SimpleActivity) {
308309

309310
return activity.getCachePhotoUri(file).toString()
310311
}
312+
313+
private fun getPreferredValue(type: String?): Int {
314+
if (type != null) {
315+
if (type.startsWith("$PREF=".lowercase())) {
316+
return type.split("=")[1].toInt()
317+
}
318+
}
319+
320+
return -1
321+
}
311322
}

0 commit comments

Comments
 (0)