Skip to content

Commit c4ac5a2

Browse files
committed
flip company and job position at getting full business contact name
1 parent 09b3f7f commit c4ac5a2

File tree

1 file changed

+13
-7
lines changed
  • app/src/main/kotlin/com/simplemobiletools/contacts/models

1 file changed

+13
-7
lines changed

app/src/main/kotlin/com/simplemobiletools/contacts/models/Contact.kt

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,18 @@ data class Contact(val id: Int, var prefix: String, var firstName: String, var m
3838
}
3939

4040
if (firstString.isEmpty() && firstName.isEmpty() && middleName.isEmpty() && surname.isEmpty()) {
41-
if (organization.company.isNotEmpty()) {
42-
firstString = organization.company.normalizeString()
41+
val fullCompany = getFullCompany()
42+
if (fullCompany.isNotEmpty()) {
43+
firstString = fullCompany.normalizeString()
4344
} else if (emails.isNotEmpty()) {
4445
firstString = emails.first().value
4546
}
4647
}
4748

4849
if (secondString.isEmpty() && other.firstName.isEmpty() && other.middleName.isEmpty() && other.surname.isEmpty()) {
49-
if (other.organization.company.isNotEmpty()) {
50-
secondString = other.organization.company.normalizeString()
50+
val otherFullCompany = other.getFullCompany()
51+
if (otherFullCompany.isNotEmpty()) {
52+
secondString = otherFullCompany.normalizeString()
5153
} else if (other.emails.isNotEmpty()) {
5254
secondString = other.emails.first().value
5355
}
@@ -95,9 +97,7 @@ data class Contact(val id: Int, var prefix: String, var firstName: String, var m
9597
val fullName = "$prefix $firstPart $lastPart$suffixComma".trim()
9698
return if (fullName.isEmpty()) {
9799
if (organization.isNotEmpty()) {
98-
var fullOrganization = if (organization.jobPosition.isEmpty()) "" else "${organization.jobPosition}, "
99-
fullOrganization += organization.company
100-
fullOrganization.trim().trimEnd(',')
100+
getFullCompany()
101101
} else {
102102
emails.firstOrNull()?.value?.trim() ?: ""
103103
}
@@ -118,6 +118,12 @@ data class Contact(val id: Int, var prefix: String, var firstName: String, var m
118118

119119
fun getHashToCompare() = getStringToCompare().hashCode()
120120

121+
fun getFullCompany(): String {
122+
var fullOrganization = if (organization.company.isEmpty()) "" else "${organization.company}, "
123+
fullOrganization += organization.jobPosition
124+
return fullOrganization.trim().trimEnd(',')
125+
}
126+
121127
fun isABusinessContact() = prefix.isEmpty() && firstName.isEmpty() && middleName.isEmpty() && surname.isEmpty() && suffix.isEmpty() && organization.isNotEmpty()
122128

123129
// do a more advanced phone number check here, compare numbers and and search query with dashes, spaces and everything but numbers removed

0 commit comments

Comments
 (0)