removing the setting for toggling scrollbar bubble

Author: tibbi

app/src/main/kotlin/com/simplemobiletools/contacts/pro/activities/SelectContactActivity.kt

@@ -199,7 +199,7 @@ class SelectContactActivity : SimpleActivity() {
                     select_contact_list.adapter = this
                 }
 
-                select_contact_fastscroller.allowBubbleDisplay = baseConfig.showInfoBubble
+                select_contact_fastscroller.allowBubbleDisplay = true
                 select_contact_fastscroller.setViews(select_contact_list) {
                     select_contact_fastscroller.updateBubbleText(contacts[it].getBubbleText())
                 }

app/src/main/kotlin/com/simplemobiletools/contacts/pro/activities/SettingsActivity.kt

@@ -37,7 +37,6 @@ class SettingsActivity : SimpleActivity() {
         setupManageSpeedDial()
         setupFontSize()
         setupUseEnglish()
-        setupShowInfoBubble()
         setupShowContactThumbnails()
         setupShowPhoneNumbers()
         setupShowContactsWithNumbers()
@@ -114,14 +113,6 @@ class SettingsActivity : SimpleActivity() {
         }
     }
 
-    private fun setupShowInfoBubble() {
-        settings_show_info_bubble.isChecked = config.showInfoBubble
-        settings_show_info_bubble_holder.setOnClickListener {
-            settings_show_info_bubble.toggle()
-            config.showInfoBubble = settings_show_info_bubble.isChecked
-        }
-    }
-
     private fun setupShowContactThumbnails() {
         settings_show_contact_thumbnails.isChecked = config.showContactThumbnails
         settings_show_contact_thumbnails_holder.setOnClickListener {

app/src/main/kotlin/com/simplemobiletools/contacts/pro/dialogs/SelectContactsDialog.kt

@@ -1,7 +1,6 @@
 package com.simplemobiletools.contacts.pro.dialogs
 
 import androidx.appcompat.app.AlertDialog
-import com.simplemobiletools.commons.extensions.baseConfig
 import com.simplemobiletools.commons.extensions.setupDialogStuff
 import com.simplemobiletools.commons.helpers.ensureBackgroundThread
 import com.simplemobiletools.contacts.pro.R
@@ -43,7 +42,7 @@ class SelectContactsDialog(val activity: SimpleActivity, initialContacts: ArrayL
                 select_contact_list.adapter = SelectContactsAdapter(activity, allContacts, initiallySelectedContacts, allowSelectMultiple,
                         select_contact_list, select_contact_fastscroller, contactClickCallback)
 
-                select_contact_fastscroller.allowBubbleDisplay = activity.baseConfig.showInfoBubble
+                select_contact_fastscroller.allowBubbleDisplay = true
                 select_contact_fastscroller.setViews(select_contact_list) {
                     select_contact_fastscroller.updateBubbleText(allContacts[it].getBubbleText())
                 }

app/src/main/kotlin/com/simplemobiletools/contacts/pro/fragments/MyViewPagerFragment.kt

@@ -357,7 +357,7 @@ abstract class MyViewPagerFragment(context: Context, attributeSet: AttributeSet)
     private fun updateViewStuff() {
         context.updateTextColors(fragment_wrapper.parent as ViewGroup)
         fragment_fastscroller?.updateBubbleColors()
-        fragment_fastscroller?.allowBubbleDisplay = config.showInfoBubble
+        fragment_fastscroller?.allowBubbleDisplay = true
         fragment_placeholder_2?.setTextColor(context.getAdjustedPrimaryColor())
         letter_fastscroller_thumb?.fontSize = context.getTextSize()
     }

app/src/main/res/layout/activity_settings.xml

@@ -172,29 +172,6 @@
 
         </RelativeLayout>
 
-        <RelativeLayout
-            android:id="@+id/settings_show_info_bubble_holder"
-            android:layout_width="match_parent"
-            android:layout_height="wrap_content"
-            android:layout_marginTop="@dimen/medium_margin"
-            android:background="?attr/selectableItemBackground"
-            android:paddingStart="@dimen/normal_margin"
-            android:paddingTop="@dimen/activity_margin"
-            android:paddingEnd="@dimen/normal_margin"
-            android:paddingBottom="@dimen/activity_margin">
-
-            <com.simplemobiletools.commons.views.MySwitchCompat
-                android:id="@+id/settings_show_info_bubble"
-                android:layout_width="match_parent"
-                android:layout_height="wrap_content"
-                android:background="@null"
-                android:clickable="false"
-                android:paddingStart="@dimen/medium_margin"
-                android:text="@string/show_info_bubble"
-                app:switchPadding="@dimen/medium_margin"/>
-
-        </RelativeLayout>
-
         <RelativeLayout
             android:id="@+id/settings_show_contact_thumbnails_holder"
             android:layout_width="match_parent"