Skip to content

Commit 12aae27

Browse files
committed
use ViewPager2 at pdf viewer
1 parent ab47bca commit 12aae27

File tree

3 files changed

+12
-19
lines changed

3 files changed

+12
-19
lines changed

app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ android {
6565

6666
dependencies {
6767
implementation 'com.github.SimpleMobileTools:Simple-Commons:b452494768'
68-
implementation 'com.github.tibbi:PdfViewPager:1bc22f031a'
68+
implementation 'com.github.tibbi:PdfViewPager:6f9641fd2c'
6969
implementation 'com.github.Stericson:RootTools:df729dcb13'
7070
implementation 'com.github.Stericson:RootShell:1.6'
7171
implementation 'com.alexvasilkov:gesture-views:2.5.2'

app/src/main/kotlin/com/simplemobiletools/filemanager/pro/activities/PDFViewerActivity.kt

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -6,23 +6,24 @@ import android.graphics.Color
66
import android.os.Bundle
77
import android.print.PrintAttributes
88
import android.print.PrintManager
9+
import android.view.View
910
import android.view.WindowManager
1011
import android.widget.RelativeLayout
12+
import androidx.viewpager2.widget.ViewPager2
1113
import com.simplemobiletools.commons.extensions.*
1214
import com.simplemobiletools.commons.helpers.REAL_FILE_PATH
1315
import com.simplemobiletools.commons.helpers.isPiePlus
1416
import com.simplemobiletools.filemanager.pro.R
1517
import com.simplemobiletools.filemanager.pro.extensions.hideSystemUI
1618
import com.simplemobiletools.filemanager.pro.extensions.showSystemUI
1719
import com.simplemobiletools.filemanager.pro.helpers.PdfDocumentAdapter
18-
import es.voghdev.pdfviewpager.library.adapter.BasePDFPagerAdapter
1920
import es.voghdev.pdfviewpager.library.adapter.PDFPagerAdapter
21+
import es.voghdev.pdfviewpager.library.adapter.PdfErrorHandler
2022
import kotlinx.android.synthetic.main.activity_pdf_viewer.*
2123

2224
class PDFViewerActivity : SimpleActivity() {
2325
private var realFilePath = ""
2426
private var isFullScreen = false
25-
private var adapter: BasePDFPagerAdapter? = null
2627

2728
override fun onCreate(savedInstanceState: Bundle?) {
2829
showTransparentTop = true
@@ -56,11 +57,6 @@ class PDFViewerActivity : SimpleActivity() {
5657
window.navigationBarColor = Color.TRANSPARENT
5758
}
5859

59-
override fun onDestroy() {
60-
super.onDestroy()
61-
adapter?.close()
62-
}
63-
6460
private fun setupMenu() {
6561
(pdf_viewer_appbar.layoutParams as RelativeLayout.LayoutParams).topMargin = statusBarHeight
6662
pdf_viewer_toolbar.menu.apply {
@@ -99,19 +95,16 @@ class PDFViewerActivity : SimpleActivity() {
9995
return
10096
}
10197

98+
pdf_viewer.orientation = ViewPager2.ORIENTATION_VERTICAL
10299
pdf_viewer.setBackgroundColor(getProperBackgroundColor())
103100

104-
adapter = PDFPagerAdapter.Builder(this)
105-
.setPdfPath(uri.toString())
106-
.setOnPageClickListener {
107-
toggleFullScreen()
108-
}
109-
.setErrorHandler { throwable ->
110-
showErrorToast(throwable.toString())
111-
}
112-
.create()
101+
val clickListener = View.OnClickListener {
102+
toggleFullScreen()
103+
}
104+
105+
val errorHandler = PdfErrorHandler { throwable -> showErrorToast(throwable.toString()) }
113106

114-
pdf_viewer.adapter = adapter
107+
pdf_viewer.adapter = PDFPagerAdapter(this, clickListener, errorHandler, uri.toString())
115108

116109
showSystemUI(true)
117110

app/src/main/res/layout/activity_pdf_viewer.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
android:layout_height="wrap_content"
77
app:layout_behavior="@string/appbar_scrolling_view_behavior">
88

9-
<es.voghdev.pdfviewpager.library.PDFViewPager
9+
<androidx.viewpager2.widget.ViewPager2
1010
android:id="@+id/pdf_viewer"
1111
android:layout_width="match_parent"
1212
android:layout_height="match_parent" />

0 commit comments

Comments
 (0)