Skip to content

Commit 895ca43

Browse files
committed
let Glide handle filetype and icon, to improve the scroll performance
1 parent 8f4dd6e commit 895ca43

File tree

11 files changed

+2
-12
lines changed

11 files changed

+2
-12
lines changed

app/src/main/kotlin/com/simplemobiletools/filemanager/adapters/ItemsAdapter.kt

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package com.simplemobiletools.filemanager.adapters
22

33
import android.content.Context
44
import android.content.res.Resources
5-
import android.graphics.Bitmap
65
import android.view.LayoutInflater
76
import android.view.View
87
import android.view.ViewGroup
@@ -13,23 +12,18 @@ import com.bumptech.glide.Glide
1312
import com.bumptech.glide.load.engine.DiskCacheStrategy
1413
import com.simplemobiletools.filemanager.R
1514
import com.simplemobiletools.filemanager.extensions.formatSize
16-
import com.simplemobiletools.filemanager.extensions.getColoredIcon
1715
import com.simplemobiletools.filepicker.models.FileDirItem
1816
import kotlinx.android.synthetic.main.list_item.view.*
1917

2018
class ItemsAdapter(context: Context, private val mItems: List<FileDirItem>) : BaseAdapter() {
2119
private val mInflater: LayoutInflater
22-
private val mFileBmp: Bitmap
23-
private val mDirectoryBmp: Bitmap
2420
private val mRes: Resources
2521
private val mContext: Context
2622

2723
init {
2824
mInflater = context.getSystemService(Context.LAYOUT_INFLATER_SERVICE) as LayoutInflater
2925
mContext = context
3026
mRes = context.resources
31-
mDirectoryBmp = mRes.getColoredIcon(R.color.lightGrey, R.mipmap.directory)
32-
mFileBmp = mRes.getColoredIcon(R.color.lightGrey, R.mipmap.file)
3327
}
3428

3529
override fun getView(position: Int, convertView: View?, parent: ViewGroup): View {
@@ -47,14 +41,10 @@ class ItemsAdapter(context: Context, private val mItems: List<FileDirItem>) : Ba
4741
viewHolder.name.text = item.name
4842

4943
if (item.isDirectory) {
50-
viewHolder.icon.setImageBitmap(mDirectoryBmp)
44+
Glide.with(mContext).load(R.mipmap.directory).diskCacheStrategy(getCacheStrategy(item)).centerCrop().crossFade().into(viewHolder.icon)
5145
viewHolder.details.text = getChildrenCnt(item)
5246
} else {
53-
if (item.isImage() || item.isVideo()) {
54-
Glide.with(mContext).load(item.path).diskCacheStrategy(getCacheStrategy(item)).centerCrop().crossFade().into(viewHolder.icon)
55-
} else {
56-
viewHolder.icon.setImageBitmap(mFileBmp)
57-
}
47+
Glide.with(mContext).load(item.path).diskCacheStrategy(getCacheStrategy(item)).error(R.mipmap.file).centerCrop().crossFade().into(viewHolder.icon)
5848
viewHolder.details.text = item.size.formatSize()
5949
}
6050

130 Bytes
Loading
158 Bytes
Loading
87 Bytes
Loading
84 Bytes
Loading
136 Bytes
Loading
149 Bytes
Loading
241 Bytes
Loading
301 Bytes
Loading
102 Bytes
Loading

0 commit comments

Comments
 (0)