Skip to content

Commit b45bc78

Browse files
committed
removing the info bubble related setting item
1 parent 61ca19d commit b45bc78

File tree

3 files changed

+3
-52
lines changed

3 files changed

+3
-52
lines changed

app/src/main/kotlin/com/simplemobiletools/filemanager/pro/activities/SettingsActivity.kt

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ class SettingsActivity : SimpleActivity() {
3535
setupAppPasswordProtection()
3636
setupFileDeletionPasswordProtection()
3737
setupKeepLastModified()
38-
setupShowInfoBubble()
3938
setupEnableRootAccess()
4039
updateTextColors(settings_holder)
4140
setupSectionColors()
@@ -49,7 +48,7 @@ class SettingsActivity : SimpleActivity() {
4948

5049
private fun setupSectionColors() {
5150
val adjustedPrimaryColor = getAdjustedPrimaryColor()
52-
arrayListOf(visibility_label, file_operations_label, scrolling_label, security_label).forEach {
51+
arrayListOf(visibility_label, file_operations_label, security_label).forEach {
5352
it.setTextColor(adjustedPrimaryColor)
5453
}
5554
}
@@ -190,14 +189,6 @@ class SettingsActivity : SimpleActivity() {
190189
}
191190
}
192191

193-
private fun setupShowInfoBubble() {
194-
settings_show_info_bubble.isChecked = config.showInfoBubble
195-
settings_show_info_bubble_holder.setOnClickListener {
196-
settings_show_info_bubble.toggle()
197-
config.showInfoBubble = settings_show_info_bubble.isChecked
198-
}
199-
}
200-
201192
private fun setupEnableRootAccess() {
202193
settings_enable_root_access_holder.beVisibleIf(config.isRootAvailable)
203194
settings_enable_root_access.isChecked = config.enableRootAccess

app/src/main/kotlin/com/simplemobiletools/filemanager/pro/fragments/ItemsFragment.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ class ItemsFragment : Fragment(), ItemOperationsListener, Breadcrumbs.Breadcrumb
9393
}
9494

9595
mView.items_fastscroller.updateBubbleColors()
96-
mView.items_fastscroller.allowBubbleDisplay = context!!.config.showInfoBubble
96+
mView.items_fastscroller.allowBubbleDisplay = true
9797
if (!isFirstResume) {
9898
refreshItems()
9999
}
@@ -155,7 +155,7 @@ class ItemsFragment : Fragment(), ItemOperationsListener, Breadcrumbs.Breadcrumb
155155
addVerticalDividers(true)
156156
items_list.adapter = this
157157
}
158-
items_fastscroller.allowBubbleDisplay = context.config.showInfoBubble
158+
items_fastscroller.allowBubbleDisplay = true
159159
items_fastscroller.setViews(items_list, mView.items_swipe_refresh) {
160160
items_fastscroller.updateBubbleText(storedItems.getOrNull(it)?.getBubbleText(context) ?: "")
161161
}

app/src/main/res/layout/activity_settings.xml

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -212,46 +212,6 @@
212212

213213
</RelativeLayout>
214214

215-
<View
216-
android:id="@+id/scrolling_divider"
217-
android:layout_width="match_parent"
218-
android:layout_height="1px"
219-
android:background="@color/divider_grey"
220-
android:importantForAccessibility="no"/>
221-
222-
<com.simplemobiletools.commons.views.MyTextView
223-
android:id="@+id/scrolling_label"
224-
android:layout_width="wrap_content"
225-
android:layout_height="wrap_content"
226-
android:layout_marginStart="@dimen/bigger_margin"
227-
android:layout_marginTop="@dimen/activity_margin"
228-
android:text="@string/scrolling"
229-
android:textAllCaps="true"
230-
android:textSize="@dimen/smaller_text_size"/>
231-
232-
<RelativeLayout
233-
android:id="@+id/settings_show_info_bubble_holder"
234-
android:layout_width="match_parent"
235-
android:layout_height="wrap_content"
236-
android:layout_marginTop="@dimen/medium_margin"
237-
android:background="?attr/selectableItemBackground"
238-
android:paddingLeft="@dimen/normal_margin"
239-
android:paddingTop="@dimen/activity_margin"
240-
android:paddingRight="@dimen/normal_margin"
241-
android:paddingBottom="@dimen/activity_margin">
242-
243-
<com.simplemobiletools.commons.views.MySwitchCompat
244-
android:id="@+id/settings_show_info_bubble"
245-
android:layout_width="match_parent"
246-
android:layout_height="wrap_content"
247-
android:background="@null"
248-
android:clickable="false"
249-
android:paddingStart="@dimen/medium_margin"
250-
android:text="@string/show_info_bubble"
251-
app:switchPadding="@dimen/medium_margin"/>
252-
253-
</RelativeLayout>
254-
255215
<View
256216
android:id="@+id/security_divider"
257217
android:layout_width="match_parent"

0 commit comments

Comments
 (0)