Skip to content

Commit f68af30

Browse files
committed
updating some dialogs with the new edittext hints
1 parent 76cbb8b commit f68af30

File tree

2 files changed

+22
-24
lines changed

2 files changed

+22
-24
lines changed

app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ android {
5858
}
5959

6060
dependencies {
61-
implementation 'com.simplemobiletools:commons:5.33.35'
61+
implementation 'com.simplemobiletools:commons:5.34.9'
6262
implementation 'com.github.Stericson:RootTools:df729dcb13'
6363
implementation 'com.github.Stericson:RootShell:1.6'
6464
implementation 'com.alexvasilkov:gesture-views:2.5.2'

app/src/main/res/layout/dialog_compress_as.xml

Lines changed: 21 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
android:id="@+id/file_path_label"
1313
android:layout_width="match_parent"
1414
android:layout_height="wrap_content"
15+
android:layout_marginStart="@dimen/small_margin"
1516
android:layout_marginTop="@dimen/activity_margin"
1617
android:text="@string/path"
1718
android:textSize="@dimen/smaller_text_size" />
@@ -21,44 +22,41 @@
2122
android:layout_width="match_parent"
2223
android:layout_height="wrap_content"
2324
android:layout_below="@+id/file_path_label"
24-
android:paddingStart="@dimen/activity_margin"
25+
android:paddingStart="@dimen/small_margin"
2526
android:paddingTop="@dimen/small_margin"
2627
android:paddingEnd="@dimen/small_margin"
2728
android:paddingBottom="@dimen/activity_margin"
29+
android:textSize="@dimen/normal_text_size"
2830
tools:text="/storage/emulated/0" />
2931

30-
<com.simplemobiletools.commons.views.MyTextView
31-
android:id="@+id/file_name_label"
32+
<com.simplemobiletools.commons.views.MyTextInputLayout
33+
android:id="@+id/file_name_hint"
3234
android:layout_width="match_parent"
3335
android:layout_height="wrap_content"
3436
android:layout_below="@+id/file_path"
35-
android:layout_marginTop="@dimen/small_margin"
36-
android:text="@string/filename"
37-
android:textSize="@dimen/smaller_text_size" />
38-
39-
<com.simplemobiletools.commons.views.MyEditText
40-
android:id="@+id/file_name"
41-
android:layout_width="match_parent"
42-
android:layout_height="wrap_content"
43-
android:layout_below="@+id/file_name_label"
44-
android:layout_marginStart="@dimen/normal_margin"
45-
android:layout_marginEnd="@dimen/medium_margin"
4637
android:layout_toStartOf="@+id/file_extension"
47-
android:inputType="textCapSentences"
48-
android:singleLine="true"
49-
android:textCursorDrawable="@null"
50-
android:textSize="@dimen/normal_text_size" />
38+
android:hint="@string/filename">
39+
40+
<com.simplemobiletools.commons.views.MyEditText
41+
android:id="@+id/file_name"
42+
android:layout_width="match_parent"
43+
android:layout_height="wrap_content"
44+
android:layout_marginEnd="@dimen/medium_margin"
45+
android:inputType="textCapSentences"
46+
android:singleLine="true"
47+
android:textCursorDrawable="@null"
48+
android:textSize="@dimen/normal_text_size" />
49+
</com.simplemobiletools.commons.views.MyTextInputLayout>
5150

5251
<com.simplemobiletools.commons.views.MyTextView
5352
android:id="@+id/file_extension"
5453
android:layout_width="wrap_content"
5554
android:layout_height="wrap_content"
56-
android:layout_below="@+id/file_name_label"
57-
android:layout_alignTop="@+id/file_name"
58-
android:layout_alignBottom="@+id/file_name"
55+
android:layout_alignBottom="@+id/file_name_hint"
5956
android:layout_alignParentEnd="true"
60-
android:gravity="center_vertical"
57+
android:layout_marginBottom="@dimen/small_margin"
6158
android:text=".zip"
62-
android:textSize="@dimen/normal_text_size" />
59+
android:textSize="@dimen/normal_text_size"
60+
tools:ignore="HardcodedText" />
6361

6462
</RelativeLayout>

0 commit comments

Comments
 (0)