update the bright display and strobo icons + misc adjustments

Author: tibbi

app/src/main/java/com/simplemobiletools/flashlight/MarshmallowCamera.java

@@ -5,6 +5,7 @@
 import android.hardware.camera2.CameraAccessException;
 import android.hardware.camera2.CameraManager;
 import android.os.Build;
+import android.os.Handler;
 import android.util.Log;
 
 import com.squareup.otto.Bus;
@@ -14,9 +15,11 @@ class MarshmallowCamera {
 
     private CameraManager manager;
     private String cameraId;
+    private Context mContext;
 
     @TargetApi(Build.VERSION_CODES.M)
     MarshmallowCamera(Context context) {
+        mContext = context;
         manager = (CameraManager) context.getSystemService(Context.CAMERA_SERVICE);
         try {
             final String[] list = manager.getCameraIdList();
@@ -31,7 +34,14 @@ void toggleMarshmallowFlashlight(final Bus bus, boolean enable) {
             manager.setTorchMode(cameraId, enable);
         } catch (CameraAccessException e) {
             Log.e(TAG, "toggle marshmallow flashlight " + e.getMessage());
-            bus.post(new Events.CameraUnavailable());
+
+            Runnable mainRunnable = new Runnable() {
+                @Override
+                public void run() {
+                    bus.post(new Events.CameraUnavailable());
+                }
+            };
+            new Handler(mContext.getMainLooper()).post(mainRunnable);
         }
     }
 }

app/src/main/java/com/simplemobiletools/flashlight/MyCameraImpl.java

@@ -67,7 +67,7 @@ public boolean toggleStroboscope() {
         return true;
     }
 
-    private void stopStroboscope() {
+    public void stopStroboscope() {
         mShouldStroboscopeStop = true;
     }
 
@@ -221,7 +221,7 @@ public void run() {
 
             if (mCamera != null) {
                 mCamera.setParameters(torchOff);
-                if (!mShouldEnableFlashlight) {
+                if (!mShouldEnableFlashlight || mIsMarshmallow) {
                     mCamera.release();
                     mCamera = null;
                 }

app/src/main/java/com/simplemobiletools/flashlight/activities/MainActivity.java

@@ -118,6 +118,7 @@ private void toggleStroboscope() {
         if (isCameraPermissionGranted()) {
             if (mCameraImpl.toggleStroboscope()) {
                 mStroboscopeBar.setVisibility(mStroboscopeBar.getVisibility() == View.VISIBLE ? View.INVISIBLE : View.VISIBLE);
+                changeIconColor(mStroboscopeBar.getVisibility() == View.VISIBLE ? R.color.colorPrimary : R.color.translucent_white, mStroboscopeBtn);
             }
         } else {
             final String[] permissions = {Manifest.permission.CAMERA};
@@ -156,7 +157,10 @@ protected void onResume() {
 
         mBrightDisplayBtn.setVisibility(mConfig.getBrightDisplay() ? View.VISIBLE : View.GONE);
         mStroboscopeBtn.setVisibility(mConfig.getStroboscope() ? View.VISIBLE : View.GONE);
-        mStroboscopeBar.setVisibility(View.INVISIBLE);
+        if (!mConfig.getStroboscope()) {
+            mCameraImpl.stopStroboscope();
+            mStroboscopeBar.setVisibility(View.INVISIBLE);
+        }
     }
 
     @Override
@@ -193,6 +197,7 @@ public void stateChangedEvent(Events.StateChanged event) {
     }
 
     public void enableFlashlight() {
+        changeIconColor(R.color.translucent_white, mStroboscopeBtn);
         changeIconColor(R.color.colorPrimary, mToggleBtn);
         getWindow().addFlags(WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON);
     }

app/src/main/res/layout/activity_main.xml

@@ -30,7 +30,7 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_marginTop="@dimen/buttons_margin"
-        android:background="@mipmap/bright_display"
+        android:background="@mipmap/stroboscope"
         android:padding="@dimen/activity_margin"/>
 
     <SeekBar