Always handle key presses

naveensingh · naveensingh · commit 96cc36d13a3f · 2023-01-31T21:25:41.000+05:30
Otherwise there won't be any click feedback when "Show key popup" is disabled
diff --git a/app/src/main/kotlin/com/simplemobiletools/keyboard/views/MyKeyboardView.kt b/app/src/main/kotlin/com/simplemobiletools/keyboard/views/MyKeyboardView.kt
@@ -753,10 +753,6 @@ class MyKeyboardView @JvmOverloads constructor(context: Context, attrs: Attribut
     }
 
     private fun showPreview(keyIndex: Int) {
-        if (!context.config.showPopupOnKeypress) {
-            return
-        }
-
         val oldKeyIndex = mCurrentKeyIndex
         val previewPopup = mPreviewPopup
         mCurrentKeyIndex = keyIndex
@@ -784,6 +780,10 @@ class MyKeyboardView @JvmOverloads constructor(context: Context, attrs: Attribut
             }
         }
 
+        if (!context.config.showPopupOnKeypress) {
+            return
+        }
+
         // If key changed and preview is on ...
         if (oldKeyIndex != mCurrentKeyIndex) {
             if (previewPopup.isShowing) {

Original file line number	Diff line number	Diff line change
`@@ -753,10 +753,6 @@ class MyKeyboardView @JvmOverloads constructor(context: Context, attrs: Attribut`
`753`	`753`	`}`
`754`	`754`
`755`	`755`	`private fun showPreview(keyIndex: Int) {`
`756`		`- if (!context.config.showPopupOnKeypress) {`
`757`		`- return`
`758`		`- }`
`759`		`-`
`760`	`756`	`val oldKeyIndex = mCurrentKeyIndex`
`761`	`757`	`val previewPopup = mPreviewPopup`
`762`	`758`	`mCurrentKeyIndex = keyIndex`
`@@ -784,6 +780,10 @@ class MyKeyboardView @JvmOverloads constructor(context: Context, attrs: Attribut`
`784`	`780`	`}`
`785`	`781`	`}`
`786`	`782`
	`783`	`+ if (!context.config.showPopupOnKeypress) {`
	`784`	`+ return`
	`785`	`+ }`
	`786`	`+`
`787`	`787`	`// If key changed and preview is on ...`
`788`	`788`	`if (oldKeyIndex != mCurrentKeyIndex) {`
`789`	`789`	`if (previewPopup.isShowing) {`