Skip to content

Commit a1a9604

Browse files
authored
Merge pull request #123 from esensar/fix/popup-menu-you-colors
Fix popup menu colors when MaterialColors returns -1
2 parents 9f951ea + 9159ecb commit a1a9604

File tree

1 file changed

+7
-1
lines changed
  • app/src/main/kotlin/com/simplemobiletools/launcher/extensions

1 file changed

+7
-1
lines changed

app/src/main/kotlin/com/simplemobiletools/launcher/extensions/Activity.kt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import com.simplemobiletools.commons.extensions.getPopupMenuTheme
2525
import com.simplemobiletools.commons.extensions.getProperTextColor
2626
import com.simplemobiletools.commons.extensions.showErrorToast
2727
import com.simplemobiletools.commons.helpers.isQPlus
28+
import com.simplemobiletools.commons.helpers.isSPlus
2829
import com.simplemobiletools.launcher.R
2930
import com.simplemobiletools.launcher.activities.SettingsActivity
3031
import com.simplemobiletools.launcher.helpers.ITEM_TYPE_FOLDER
@@ -90,7 +91,12 @@ fun Activity.handleGridItemPopupMenu(anchorView: View, gridItem: HomeScreenGridI
9091

9192
inflate(R.menu.menu_app_icon)
9293
menu.forEach {
93-
val color = MaterialColors.getColor(contextTheme, android.R.attr.textColorPrimary, getProperTextColor())
94+
val default = getProperTextColor()
95+
val color = if (isSPlus() && config.isUsingSystemTheme) {
96+
default
97+
} else {
98+
MaterialColors.getColor(contextTheme, android.R.attr.actionMenuTextColor, default)
99+
}
94100
it.iconTintList = ColorStateList.valueOf(color)
95101
}
96102
menu.findItem(R.id.rename).isVisible = (gridItem.type == ITEM_TYPE_ICON || gridItem.type == ITEM_TYPE_FOLDER) && !isOnAllAppsFragment

0 commit comments

Comments
 (0)