Skip to content

Commit 08bf07f

Browse files
committed
create a config context extension
1 parent bf86fde commit 08bf07f

File tree

8 files changed

+17
-18
lines changed

8 files changed

+17
-18
lines changed

app/src/main/kotlin/com/simplemobiletools/notes/activities/MainActivity.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import com.simplemobiletools.notes.adapters.NotesPagerAdapter
2323
import com.simplemobiletools.notes.dialogs.NewNoteDialog
2424
import com.simplemobiletools.notes.dialogs.OpenNoteDialog
2525
import com.simplemobiletools.notes.dialogs.RenameNoteDialog
26+
import com.simplemobiletools.notes.extensions.config
2627
import com.simplemobiletools.notes.extensions.getTextSize
2728
import com.simplemobiletools.notes.helpers.DBHelper
2829
import com.simplemobiletools.notes.helpers.TYPE_NOTE

app/src/main/kotlin/com/simplemobiletools/notes/activities/SettingsActivity.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import android.widget.AdapterView
66
import android.widget.ArrayAdapter
77
import com.simplemobiletools.commons.extensions.updateTextColors
88
import com.simplemobiletools.notes.R
9+
import com.simplemobiletools.notes.extensions.config
910
import com.simplemobiletools.notes.extensions.updateWidget
1011
import com.simplemobiletools.notes.helpers.DBHelper
1112
import com.simplemobiletools.notes.models.Note

app/src/main/kotlin/com/simplemobiletools/notes/activities/SimpleActivity.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,9 @@ package com.simplemobiletools.notes.activities
22

33
import android.os.Bundle
44
import com.simplemobiletools.commons.activities.BaseSimpleActivity
5-
import com.simplemobiletools.notes.helpers.Config
65

76
open class SimpleActivity : BaseSimpleActivity() {
8-
lateinit var config: Config
9-
107
override fun onCreate(savedInstanceState: Bundle?) {
118
super.onCreate(savedInstanceState)
12-
config = Config.newInstance(applicationContext)
139
}
1410
}

app/src/main/kotlin/com/simplemobiletools/notes/activities/WidgetConfigureActivity.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ import android.widget.RemoteViews
1111
import android.widget.SeekBar
1212
import com.simplemobiletools.commons.dialogs.ColorPickerDialog
1313
import com.simplemobiletools.notes.R
14+
import com.simplemobiletools.notes.extensions.config
1415
import com.simplemobiletools.notes.extensions.getTextSize
15-
import com.simplemobiletools.notes.helpers.Config
1616
import com.simplemobiletools.notes.helpers.MyWidgetProvider
1717
import kotlinx.android.synthetic.main.widget_config.*
1818

@@ -47,7 +47,6 @@ class WidgetConfigureActivity : AppCompatActivity() {
4747
}
4848

4949
private fun initVariables() {
50-
val config = Config.newInstance(this)
5150
mBgColor = config.widgetBgColor
5251
if (mBgColor == 1) {
5352
mBgColor = Color.BLACK
@@ -83,7 +82,7 @@ class WidgetConfigureActivity : AppCompatActivity() {
8382
}
8483

8584
private fun storeWidgetBackground() {
86-
Config.newInstance(this).apply {
85+
config.apply {
8786
widgetBgColor = mBgColor
8887
widgetTextColor = mTextColor
8988
}

app/src/main/kotlin/com/simplemobiletools/notes/dialogs/OpenNoteDialog.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,15 @@ import android.widget.RadioButton
77
import android.widget.RadioGroup
88
import com.simplemobiletools.commons.extensions.setupDialogStuff
99
import com.simplemobiletools.notes.R
10+
import com.simplemobiletools.notes.extensions.config
1011
import com.simplemobiletools.notes.helpers.DBHelper
11-
import com.simplemobiletools.notes.helpers.Config
1212
import kotlinx.android.synthetic.main.dialog_radio_group.view.*
1313

1414
class OpenNoteDialog(val activity: Activity, val callback: (checkedId: Int) -> Unit) : RadioGroup.OnCheckedChangeListener {
1515
val dialog: AlertDialog?
1616
var wasInit = false
1717

1818
init {
19-
val config = Config.newInstance(activity)
2019
val view = activity.layoutInflater.inflate(R.layout.dialog_radio_group, null)
2120
val radioGroup = view.dialog_radio_group
2221
radioGroup.setOnCheckedChangeListener(this)
@@ -26,7 +25,7 @@ class OpenNoteDialog(val activity: Activity, val callback: (checkedId: Int) -> U
2625
val radioButton = activity.layoutInflater.inflate(R.layout.radio_button, null) as RadioButton
2726
radioButton.apply {
2827
text = it.title
29-
isChecked = it.id == config.currentNoteId
28+
isChecked = it.id == activity.config.currentNoteId
3029
id = it.id
3130
}
3231
radioGroup.addView(radioButton, RadioGroup.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.WRAP_CONTENT))

app/src/main/kotlin/com/simplemobiletools/notes/extensions/Context.kt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,19 @@ import android.content.ComponentName
55
import android.content.Context
66
import android.content.Intent
77
import android.view.Gravity
8-
import com.simplemobiletools.notes.*
8+
import com.simplemobiletools.notes.R
99
import com.simplemobiletools.notes.helpers.*
1010

1111
fun Context.getTextSize() =
12-
when (Config.newInstance(this).fontSize) {
12+
when (config.fontSize) {
1313
FONT_SIZE_SMALL -> resources.getDimension(R.dimen.smaller_text_size)
1414
FONT_SIZE_LARGE -> resources.getDimension(R.dimen.big_text_size)
1515
FONT_SIZE_EXTRA_LARGE -> resources.getDimension(R.dimen.extra_big_text_size)
1616
else -> resources.getDimension(R.dimen.bigger_text_size)
1717
}
1818

1919
fun Context.getTextGravity() =
20-
when (Config.newInstance(this).gravity) {
20+
when (config.gravity) {
2121
GRAVITY_CENTER -> Gravity.CENTER_HORIZONTAL
2222
GRAVITY_RIGHT -> Gravity.RIGHT
2323
else -> Gravity.LEFT
@@ -33,3 +33,5 @@ fun Context.updateWidget() {
3333
sendBroadcast(this)
3434
}
3535
}
36+
37+
val Context.config: Config get() = Config.newInstance(this)

app/src/main/kotlin/com/simplemobiletools/notes/fragments/NoteFragment.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ import android.view.ViewGroup
1010
import android.view.inputmethod.InputMethodManager
1111
import com.simplemobiletools.commons.extensions.value
1212
import com.simplemobiletools.notes.R
13+
import com.simplemobiletools.notes.extensions.config
1314
import com.simplemobiletools.notes.extensions.getTextGravity
1415
import com.simplemobiletools.notes.extensions.getTextSize
1516
import com.simplemobiletools.notes.extensions.updateWidget
16-
import com.simplemobiletools.notes.helpers.Config
1717
import com.simplemobiletools.notes.helpers.DBHelper
1818
import com.simplemobiletools.notes.helpers.NOTE_ID
1919
import com.simplemobiletools.notes.models.Note
@@ -52,7 +52,7 @@ class NoteFragment : Fragment() {
5252
override fun onResume() {
5353
super.onResume()
5454

55-
val config = Config.newInstance(context)
55+
val config = context.config
5656
view.notes_view.apply {
5757
setText(note.value)
5858
setColors(config.textColor, config.primaryColor, config.backgroundColor)

app/src/main/kotlin/com/simplemobiletools/notes/helpers/MyWidgetProvider.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import android.widget.RemoteViews
1010
import com.simplemobiletools.notes.R
1111
import com.simplemobiletools.notes.R.layout.widget
1212
import com.simplemobiletools.notes.activities.MainActivity
13+
import com.simplemobiletools.notes.extensions.config
1314
import com.simplemobiletools.notes.extensions.getTextSize
1415

1516
class MyWidgetProvider : AppWidgetProvider() {
@@ -22,7 +23,7 @@ class MyWidgetProvider : AppWidgetProvider() {
2223

2324
override fun onUpdate(context: Context, appWidgetManager: AppWidgetManager, appWidgetIds: IntArray) {
2425
initVariables(context)
25-
val config = Config.newInstance(context)
26+
val config = context.config
2627
val widgetBgColor = config.widgetBgColor
2728
val widgetTextColor = config.widgetTextColor
2829

@@ -44,7 +45,7 @@ class MyWidgetProvider : AppWidgetProvider() {
4445
}
4546

4647
private fun getProperTextView(context: Context): Int {
47-
return when (Config.newInstance(context).gravity) {
48+
return when (context.config.gravity) {
4849
GRAVITY_CENTER -> R.id.notes_view_center
4950
GRAVITY_RIGHT -> R.id.notes_view_right
5051
else -> R.id.notes_view_left
@@ -64,7 +65,7 @@ class MyWidgetProvider : AppWidgetProvider() {
6465
}
6566

6667
private fun updateWidget(widgetManager: AppWidgetManager, widgetId: Int, remoteViews: RemoteViews, context: Context) {
67-
val note = mDb.getNote(Config.newInstance(context).widgetNoteId)
68+
val note = mDb.getNote(context.config.widgetNoteId)
6869
for (id in textIds)
6970
remoteViews.setTextViewText(id, note?.value ?: "")
7071
widgetManager.updateAppWidget(widgetId, remoteViews)

0 commit comments

Comments
 (0)