tweaking the way checklist items are moved to the top or bottom

Author: tibbi

app/build.gradle

@@ -57,7 +57,7 @@ android {
 }
 
 dependencies {
-    implementation 'com.simplemobiletools:commons:5.32.24'
+    implementation 'com.simplemobiletools:commons:5.33.7'
     implementation 'androidx.constraintlayout:constraintlayout:2.0.4'
     implementation 'androidx.documentfile:documentfile:1.0.1'
 

app/src/main/kotlin/com/simplemobiletools/notes/pro/adapters/ChecklistAdapter.kt

@@ -148,26 +148,25 @@ class ChecklistAdapter(activity: BaseSimpleActivity, var items: ArrayList<Checkl
     }
 
     private fun moveSelectedItemsToTop() {
-        selectedKeys.withIndex()
-                .reversed()
-                .forEach { keys ->
-                    val position = items.indexOfFirst { it.id == keys.value }
-                    val tempItem = items[position]
-                    items.removeAt(position)
-                    items.add(0, tempItem)
-                }
+        selectedKeys.reversed().forEach { checklistId ->
+            val position = items.indexOfFirst { it.id == checklistId }
+            val tempItem = items[position]
+            items.removeAt(position)
+            items.add(0, tempItem)
+        }
+
         notifyDataSetChanged()
         listener?.saveChecklist()
     }
 
     private fun moveSelectedItemsToBottom() {
-        selectedKeys.withIndex()
-                .forEach { keys ->
-                    val position = items.indexOfFirst { it.id == keys.value }
-                    val tempItem = items[position]
-                    items.removeAt(position)
-                    items.add(items.size, tempItem)
-                }
+        selectedKeys.forEach { checklistId ->
+            val position = items.indexOfFirst { it.id == checklistId }
+            val tempItem = items[position]
+            items.removeAt(position)
+            items.add(items.size, tempItem)
+        }
+
         notifyDataSetChanged()
         listener?.saveChecklist()
     }