Skip to content

Commit c3e7895

Browse files
committed
tweaking a string to make it clearer
1 parent 195bb25 commit c3e7895

File tree

37 files changed

+40
-40
lines changed

37 files changed

+40
-40
lines changed

app/src/main/kotlin/com/simplemobiletools/notes/pro/activities/SettingsActivity.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,10 @@ class SettingsActivity : SimpleActivity() {
132132
}
133133

134134
private fun setupMoveUndoneChecklistItems() {
135-
settings_move_undone_checklist_items.isChecked = config.moveUndoneChecklistItems
135+
settings_move_undone_checklist_items.isChecked = config.moveDoneChecklistItems
136136
settings_move_undone_checklist_items_holder.setOnClickListener {
137137
settings_move_undone_checklist_items.toggle()
138-
config.moveUndoneChecklistItems = settings_move_undone_checklist_items.isChecked
138+
config.moveDoneChecklistItems = settings_move_undone_checklist_items.isChecked
139139
}
140140
}
141141

app/src/main/kotlin/com/simplemobiletools/notes/pro/adapters/WidgetAdapter.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ class WidgetAdapter(val context: Context, val intent: Intent) : RemoteViewsServi
9494
if (note?.type == NoteType.TYPE_CHECKLIST.value) {
9595
val checklistItemType = object : TypeToken<List<ChecklistItem>>() {}.type
9696
checklistItems = Gson().fromJson<ArrayList<ChecklistItem>>(note!!.value, checklistItemType) ?: ArrayList(1)
97-
if (context.config.moveUndoneChecklistItems) {
97+
if (context.config.moveDoneChecklistItems) {
9898
checklistItems.sortBy { it.isDone }
9999
}
100100
}

app/src/main/kotlin/com/simplemobiletools/notes/pro/fragments/ChecklistFragment.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ class ChecklistFragment : NoteFragment(), ChecklistItemsListener {
6666
migrateCheckListOnFailure(storedNote)
6767
}
6868

69-
if (config?.moveUndoneChecklistItems == true) {
69+
if (config?.moveDoneChecklistItems == true) {
7070
items.sortBy { it.isDone }
7171
}
7272

app/src/main/kotlin/com/simplemobiletools/notes/pro/helpers/Config.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,9 @@ class Config(context: Context) : BaseConfig(context) {
7575
get() = prefs.getInt(LAST_CREATED_NOTE_TYPE, NoteType.TYPE_TEXT.value)
7676
set(lastCreatedNoteType) = prefs.edit().putInt(LAST_CREATED_NOTE_TYPE, lastCreatedNoteType).apply()
7777

78-
var moveUndoneChecklistItems: Boolean
79-
get() = prefs.getBoolean(MOVE_UNDONE_CHECKLIST_ITEMS, false)
80-
set(moveUndoneChecklistItems) = prefs.edit().putBoolean(MOVE_UNDONE_CHECKLIST_ITEMS, moveUndoneChecklistItems).apply()
78+
var moveDoneChecklistItems: Boolean
79+
get() = prefs.getBoolean(MOVE_DONE_CHECKLIST_ITEMS, false)
80+
set(moveDoneChecklistItems) = prefs.edit().putBoolean(MOVE_DONE_CHECKLIST_ITEMS, moveDoneChecklistItems).apply()
8181

8282
@SuppressLint("RtlHardcoded")
8383
fun getTextGravity() = when (gravity) {

app/src/main/kotlin/com/simplemobiletools/notes/pro/helpers/Constants.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const val LAST_USED_SAVE_PATH = "last_used_save_path"
2929
const val ENABLE_LINE_WRAP = "enable_line_wrap"
3030
const val USE_INCOGNITO_MODE = "use_incognito_mode"
3131
const val LAST_CREATED_NOTE_TYPE = "last_created_note_type"
32-
const val MOVE_UNDONE_CHECKLIST_ITEMS = "move_undone_checklist_items"
32+
const val MOVE_DONE_CHECKLIST_ITEMS = "move_undone_checklist_items" // it has been replaced from moving undone items at the top to moving done to bottom
3333
const val FONT_SIZE_PERCENTAGE = "font_size_percentage"
3434

3535
// gravity

app/src/main/res/layout/activity_settings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@
341341
android:background="@null"
342342
android:clickable="false"
343343
android:paddingStart="@dimen/medium_margin"
344-
android:text="@string/move_undone_checklist_items"
344+
android:text="@string/move_done_checklist_items"
345345
app:switchPadding="@dimen/medium_margin" />
346346

347347
</RelativeLayout>

app/src/main/res/values-ar/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
<string name="autosave_notes">حفظ الملاحظات تلقائيا</string>
4949
<string name="enable_line_wrap">تفعيل التفاف الخط</string>
5050
<string name="use_incognito_mode">استخدام وضع التصفح المتخفي للوحات المفاتيح</string>
51-
<string name="move_undone_checklist_items">Move undone checklist items at the top</string>
51+
<string name="move_done_checklist_items">Move done checklist items to the bottom</string>
5252

5353
<!-- Checklists -->
5454
<string name="checklist">قائمة تدقيق</string>

app/src/main/res/values-az/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
<string name="autosave_notes">Qeydləri avtomatik saxla</string>
4949
<string name="enable_line_wrap">Cız sarğısını göstər</string>
5050
<string name="use_incognito_mode">Use Incognito mode of keyboards</string>
51-
<string name="move_undone_checklist_items">Move undone checklist items at the top</string>
51+
<string name="move_done_checklist_items">Move done checklist items to the bottom</string>
5252

5353
<!-- Checklists -->
5454
<string name="checklist">Checklist</string>

app/src/main/res/values-cs/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
<string name="autosave_notes">Automaticky ukládat poznámky</string>
4949
<string name="enable_line_wrap">Povolit zalamování řádků</string>
5050
<string name="use_incognito_mode">Použít Inkognito mód klávesnic</string>
51-
<string name="move_undone_checklist_items">Přesunout nesplněné položky seznamu položek nahoru</string>
51+
<string name="move_done_checklist_items">Přesunout splněné položky seznamu položek nadol</string>
5252

5353
<!-- Checklists -->
5454
<string name="checklist">Seznam položek</string>

app/src/main/res/values-cy/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
<string name="autosave_notes">Awto-gadw nodiadau</string>
4949
<string name="enable_line_wrap">Galluogi amlapio llinellau</string>
5050
<string name="use_incognito_mode">Defnyddio modd cyfrinachol bysellfyrddau</string>
51-
<string name="move_undone_checklist_items">Move undone checklist items at the top</string>
51+
<string name="move_done_checklist_items">Move done checklist items to the bottom</string>
5252

5353
<!-- Checklists -->
5454
<string name="checklist">Rhestr wirio</string>

0 commit comments

Comments
 (0)