test(ci): guard react package exports too via shared scripts/check-exports.mjs

Author: bendersej

.github/workflows/embed.yaml

@@ -39,3 +39,6 @@ jobs:
 
       - name: Bundle size budgets
         run: npm run --workspace @simplepdf/embed check:size
+
+      - name: Export load
+        run: npm run --workspace @simplepdf/embed check:exports

.github/workflows/react.yaml

@@ -38,6 +38,9 @@ jobs:
       - name: Build the core
         run: npm run --workspace @simplepdf/embed build
 
+      - name: Build react-embed-pdf
+        run: npm run --workspace @simplepdf/react-embed-pdf build
+
       - name: Formatting
         run: npm run --workspace @simplepdf/react-embed-pdf test:format
 
@@ -46,3 +49,6 @@ jobs:
 
       - name: Tests
         run: npm run --workspace @simplepdf/react-embed-pdf test
+
+      - name: Export load
+        run: npm run --workspace @simplepdf/react-embed-pdf check:exports

embed/package.json

@@ -63,7 +63,8 @@
     "pretest": "npm run generate",
     "test": "vitest run",
     "test:watch": "vitest",
-    "check:size": "npm run build && node scripts/check-bundle-size.mjs"
+    "check:size": "npm run build && node scripts/check-bundle-size.mjs",
+    "check:exports": "node ../scripts/check-exports.mjs ."
   },
   "peerDependencies": {
     "@tanstack/ai": "^0.38.0",

embed/scripts/check-bundle-size.mjs

@@ -1,11 +1,9 @@
-// Build verification, run after `npm run build`. (1) Gzips each public entry's local
+// Bundle-size budget guard, run after `npm run build`. Gzips each public entry's local
 // closure (the entry file plus the dist chunks it imports; peer deps are external and
-// never counted) and fails if any entry exceeds its budget. (2) Loads every public
-// subpath per its export conditions, so an entry that resolves but throws at load (e.g.
-// a CJS bundle requiring an ESM-only peer) fails here, not at the consumer.
+// never counted) and fails if any entry exceeds its budget. Export loadability is guarded
+// separately by ../../scripts/check-exports.mjs (the `check:exports` script).
 
 import { existsSync, readFileSync } from 'node:fs'
-import { createRequire } from 'node:module'
 import { dirname, join } from 'node:path'
 import { fileURLToPath } from 'node:url'
 import { gzipSync } from 'node:zlib'
@@ -58,26 +56,4 @@ const allWithinBudget = Object.entries(BUDGETS).map(([entry, budget]) => {
   console.log(`${ok ? '✓' : '✗'} ${entry}: ${size} B gzip (budget ${budget} B)`)
   return ok
 })
-// Load every public subpath the way its export map advertises it.
-const require = createRequire(import.meta.url)
-const pkg = JSON.parse(readFileSync(join(DIST, '..', 'package.json'), 'utf8'))
-const load = { require: (spec) => require(spec), import: (spec) => import(spec) }
-const exportsLoad = []
-for (const [subpath, conditions] of Object.entries(pkg.exports)) {
-  const spec = subpath === '.' ? pkg.name : `${pkg.name}/${subpath.slice(2)}`
-  for (const condition of ['require', 'import']) {
-    if (conditions[condition] === undefined) {
-      continue
-    }
-    try {
-      await load[condition](spec)
-      console.log(`✓ ${spec} [${condition}] loads`)
-      exportsLoad.push(true)
-    } catch (error) {
-      console.error(`✗ ${spec} [${condition}]: ${error.code ?? error.message}`)
-      exportsLoad.push(false)
-    }
-  }
-}
-
-process.exit([...allWithinBudget, ...exportsLoad].every(Boolean) ? 0 : 1)
+process.exit(allWithinBudget.every(Boolean) ? 0 : 1)

react/package.json

@@ -44,7 +44,8 @@
     "format": "npm run prettier -- --write",
     "prepublishOnly": "rimraf dist && npm run build",
     "build": "rollup -c",
-    "start": "rollup -c -w"
+    "start": "rollup -c -w",
+    "check:exports": "node ../scripts/check-exports.mjs ."
   },
   "dependencies": {
     "@simplepdf/embed": "^0.5.0"

scripts/check-exports.mjs

@@ -0,0 +1,35 @@
+// Export-load guard, shared by the workspace packages. Loads every public subpath of a
+// built package per its export conditions (require + import), so an entry that resolves
+// but throws at load (e.g. a CJS bundle requiring an ESM-only peer) fails CI, not the
+// consumer. Run after that package's build.
+//
+//   node ../scripts/check-exports.mjs <packageDir>   (defaults to the cwd)
+
+import { readFileSync } from 'node:fs'
+import { createRequire } from 'node:module'
+import { resolve } from 'node:path'
+
+const packageDir = resolve(process.argv[2] ?? '.')
+const pkg = JSON.parse(readFileSync(resolve(packageDir, 'package.json'), 'utf8'))
+const require = createRequire(import.meta.url)
+const load = { require: (spec) => require(spec), import: (spec) => import(spec) }
+
+const results = []
+for (const [subpath, conditions] of Object.entries(pkg.exports)) {
+  const spec = subpath === '.' ? pkg.name : `${pkg.name}/${subpath.slice(2)}`
+  for (const condition of ['require', 'import']) {
+    if (conditions[condition] === undefined) {
+      continue
+    }
+    try {
+      await load[condition](spec)
+      console.log(`✓ ${spec} [${condition}]`)
+      results.push(true)
+    } catch (error) {
+      console.error(`✗ ${spec} [${condition}]: ${error.code ?? error.message}`)
+      results.push(false)
+    }
+  }
+}
+
+process.exit(results.every(Boolean) ? 0 : 1)