Removed Submit method in base-form. Moved it's contents to form-store to handle submit result.

Author: Martynas Žilinskas

package.json

@@ -3,11 +3,7 @@
   "private": true,
   "scripts": {},
   "devDependencies": {
-    "babel-core": "^6.24.1",
-    "babel-preset-es2015": "^6.24.1",
-    "gulp": "github:gulpjs/gulp#4.0",
     "lerna": "2.0.0-rc.1",
-    "typescript": "2.3.0",
-    "webpack-stream": "^3.2.0"
+    "typescript": "2.3.0"
   }
 }

packages/simplr-forms-core/src/abstractions/base-form.ts

@@ -44,23 +44,6 @@ export abstract class BaseForm<TProps extends FormContracts.FormProps, TState> e
         return this.FormStore.GetState().Form.Error == null;
     }
 
-    protected async Submit(result: Promise<void> | FormError | any): Promise<void> {
-        let promise: Promise<void>;
-        if (this.isPromise<void>(result)) {
-            promise = result;
-        } else {
-            promise = new Promise<void>((resolve, reject) => {
-                const error = ConstructFormError(result);
-                if (error !== undefined) {
-                    reject(result);
-                    return;
-                }
-                resolve(result);
-            });
-        }
-        await this.FormStore.Submit(promise);
-    }
-
     componentWillUnmount() {
         if (this.props.destroyOnUnmount) {
             this.FormStoresHandler.UnregisterForm(this.FormId);
@@ -96,8 +79,4 @@ export abstract class BaseForm<TProps extends FormContracts.FormProps, TState> e
             }
         }
     }
-
-    private isPromise<T>(value: any): value is Promise<T> {
-        return value != null && value.then != null && value.catch != null;
-    }
 }

packages/simplr-forms-core/src/stores/form-store.ts

@@ -212,7 +212,21 @@ export class FormStore extends ActionEmitter {
         this.State.Form.SubmitCallback();
     }
 
-    public async Submit(promise: Promise<void>) {
+    public async Submit(result: Promise<void> | FormError | any) {
+        let promise: Promise<void>;
+        if (this.IsPromise<void>(result)) {
+            promise = result;
+        } else {
+            promise = new Promise<void>((resolve, reject) => {
+                const error = ConstructFormError(result);
+                if (error !== undefined) {
+                    reject(result);
+                    return;
+                }
+                resolve(result);
+            });
+        }
+
         // Form.Submitting -> true
         this.State = this.State.withMutations(state => {
             state.Form = state.Form.merge({
@@ -279,4 +293,8 @@ export class FormStore extends ActionEmitter {
             Props: undefined
         };
     }
+
+    protected IsPromise<T>(value: any): value is Promise<T> {
+        return value != null && value.then != null && value.catch != null;
+    }
 }

packages/simplr-forms-dom/src/components/form.tsx

@@ -36,7 +36,7 @@ export class Form extends BaseForm<FormProps, {}> {
         event.persist();
 
         const result = this.props.onSubmit(event, this.FormStore);
-        this.Submit(result);
+        this.FormStore.Submit(result);
     }
 
     render() {