Skip to content

Commit d596362

Browse files
simplr-forms-dom updated to suite new exports from simplr-forms-core.
1 parent 17249a0 commit d596362

File tree

7 files changed

+29
-19
lines changed

7 files changed

+29
-19
lines changed

packages/simplr-forms-core/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
"description": "Shared simplr-forms logic.",
55
"repository": "SimplrJS/simplr-forms",
66
"homepage": "https://github.com/SimplrJS/simplr-forms",
7-
"main": "dist/simplr-forms-core.js",
8-
"types": "@types/index.d.ts",
7+
"main": "main.js",
8+
"types": "index.d.ts",
99
"author": "simplrjs <[email protected]> (https://github.com/simplrjs)",
1010
"scripts": {
1111
"build": "webpack && npm run tslint",

packages/simplr-forms-core/webpack.config.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
const packageJson = require("./package.json");
22
const path = require("path");
33

4-
var WebpackOnBuildPlugin = require('on-build-webpack');
5-
var childProcess = require('child_process');
4+
const WebpackOnBuildPlugin = require('on-build-webpack');
5+
const childProcess = require('child_process');
66

77
let externals = {};
88

9-
for (let key in packageJson.dependencies) {
9+
for (const key in packageJson.dependencies) {
1010
externals[key] = key;
1111
}
1212

13-
let externalsResolver = [
13+
const externalsResolver = [
1414
externals,
1515
function (context, request, callback) {
1616
const directoriesToTest = [

packages/simplr-forms-dom/src/abstractions/base-dom-field.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
import * as React from "react";
2-
import { Abstractions as CoreAbstractions, Contracts as CoreContracts } from "simplr-forms-core";
2+
import { BaseField, BaseFieldState } from "simplr-forms-core";
3+
import { FieldProps } from "simplr-forms-core/contracts";
34

4-
export interface BaseDomFieldState extends CoreAbstractions.BaseFieldState {
5+
export interface BaseDomFieldState extends BaseFieldState {
56

67
}
78

8-
export abstract class BaseDomField<TProps extends CoreContracts.FieldProps, TState extends BaseDomFieldState>
9-
extends CoreAbstractions.BaseField<TProps, TState> {
9+
export abstract class BaseDomField<TProps extends FieldProps, TState extends BaseDomFieldState>
10+
extends BaseField<TProps, TState> {
1011
public abstract renderField(): JSX.Element | null;
1112

1213
public render() {

packages/simplr-forms-dom/src/components/form.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
import * as React from "react";
2-
import { Abstractions as CoreAbstractions, Contracts as CoreContracts } from "simplr-forms-core";
2+
import { BaseForm } from "simplr-forms-core";
3+
import { FormProps } from "simplr-forms-core/contracts";
34
import { OnChangeCallback } from "../contracts/field";
45
import { FormOnSubmitCallback } from "../contracts/form";
56

6-
export interface FormProps extends CoreContracts.FormProps, React.HTMLProps<HTMLFormElement> {
7+
export interface FormProps extends FormProps, React.HTMLProps<HTMLFormElement> {
78
onSubmit?: FormOnSubmitCallback;
89
onChange?: OnChangeCallback<any>;
910
}
1011

11-
export class Form extends CoreAbstractions.BaseForm<FormProps, {}> {
12+
export class Form extends BaseForm<FormProps, {}> {
1213
render() {
1314
return <form>
1415
{this.props.children}
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
import { Contracts as CoreContracts } from "simplr-forms-core";
1+
import * as React from "react";
2+
import { FieldValue } from "simplr-forms-core/contracts";
23

34
export interface OnChangeCallback<TElement> extends React.EventHandler<React.FormEvent<TElement>> {
4-
(event: React.FormEvent<TElement> | undefined, newValue: CoreContracts.FieldValue, fieldId: string, formId: string): void;
5+
(event: React.FormEvent<TElement> | undefined, newValue: FieldValue, fieldId: string, formId: string): void;
56
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
import * as React from "react";
2+
import { FieldValue, FormError } from "simplr-forms-core/contracts";
3+
import { FormStore } from "simplr-forms-core/stores";
4+
5+
export interface FormOnSubmitCallback extends React.FormEventHandler<HTMLFormElement> {
6+
(event: React.FormEvent<HTMLFormElement>, store: FormStore): void | Promise<any> | FormError | string;
7+
}

packages/simplr-forms-dom/webpack.config.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@ const packageJson = require("./package.json");
22
const tsConfig = require("./tsconfig.json");
33
const path = require("path");
44

5-
var WebpackOnBuildPlugin = require('on-build-webpack');
6-
var childProcess = require('child_process');
5+
const WebpackOnBuildPlugin = require('on-build-webpack');
6+
const childProcess = require('child_process');
77

88
let externals = {};
99

10-
for (let key in packageJson.dependencies) {
10+
for (const key in packageJson.dependencies) {
1111
externals[key] = key;
1212
}
1313

14-
let externalsResolver = [
14+
const externalsResolver = [
1515
externals,
1616
function (context, request, callback) {
1717
if (/.*\/abstractions\/.+$/.test(request)) {

0 commit comments

Comments
 (0)