memset to detect use after free, most likely a race condition.

cjavad · cjavad · commit aef715ddef45 · 2025-05-15T19:41:02.000+02:00
diff --git a/ext-src/swoole_coroutine.cc b/ext-src/swoole_coroutine.cc
@@ -650,6 +650,9 @@ void PHPCoroutine::on_close(void *arg) {
     if (ctx->on_close) {
         (*ctx->on_close)(ctx);
     }
+
+    // Mark memory region with special byte pattern to detect use-after-free
+    memset(ctx, 0xAA, sizeof(PHPContext));
     efree(ctx);
 }
 
diff --git a/quick-configure-test.sh b/quick-configure-test.sh
@@ -0,0 +1,3 @@
+#!/bin/sh
+phpize
+./configure --enable-swoole-curl --enable-swoole --enable-openssl --enable-sockets --enable-mysqlnd --enable-debug

Original file line number	Diff line number	Diff line change
`@@ -650,6 +650,9 @@ void PHPCoroutine::on_close(void *arg) {`
`650`	`650`	`if (ctx->on_close) {`
`651`	`651`	`(*ctx->on_close)(ctx);`
`652`	`652`	`}`
	`653`	`+`
	`654`	`+ // Mark memory region with special byte pattern to detect use-after-free`
	`655`	`+ memset(ctx, 0xAA, sizeof(PHPContext));`
`653`	`656`	`efree(ctx);`
`654`	`657`	`}`
`655`	`658`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+#!/bin/sh`
	`2`	`+phpize`
	`3`	`+./configure --enable-swoole-curl --enable-swoole --enable-openssl --enable-sockets --enable-mysqlnd --enable-debug`