Merge pull request mozilla#242 from mozilla/use-fallible_collections-crate

Switch to using fallible_collections crate

Author: baumanj

.travis.yml

@@ -27,11 +27,6 @@ install:
     fi
 
 script:
-  # We cannot run `cargo test` with the mp4parse_fallible feature enabled
-  # (see comment where the feature is defined in mp4parse_capi/Cargo.toml),
-  # but we can at least check for changes behind features that would break the
-  # build.
-  - cargo check --all --verbose $RELEASE --tests --all-features
   - cargo test --all --verbose $RELEASE ${TARGET:+--target=$TARGET}
   - cargo doc --package mp4parse_capi
   # The `false` after `echo` is necessary to avoid false negatives due to `echo` returning success

mp4parse/Cargo.toml

@@ -27,6 +27,7 @@ travis-ci = { repository = "https://github.com/mozilla/mp4parse-rust" }
 [dependencies]
 byteorder = "1.2.1"
 bitreader = { version = "0.3.2" }
+fallible_collections = { version = "0.1.3", features = ["std_io"] }
 hashbrown = "0.7.1"
 num-traits = "=0.2.10"
 log = "0.4"
@@ -36,9 +37,3 @@ static_assertions = "1.1.0"
 test-assembler = "0.1.2"
 env_logger = "0.7.1"
 walkdir = "2.3.1"
-
-[features]
-# Enable mp4parse_fallible to use fallible memory allocation rather than
-# panicking on OOM.  Note that this is only safe within Gecko where the system
-# allocator has been globally overridden (see BMO 1457359).
-mp4parse_fallible = []