Enable and resolve some of the compile-time warnings.

Author: LTLA

lib/CMakeLists.txt

@@ -25,6 +25,9 @@ target_include_directories(singler PRIVATE "${KNNCOLLE_INCLUDE_DIR}")
 set_property(TARGET singler PROPERTY CXX_STANDARD 17)
 
 target_link_libraries(singler PRIVATE pybind11::pybind11)
+if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
+    target_compile_options(singler PRIVATE -Wall -Wpedantic -Wextra)
+endif()
 
 set_target_properties(singler PROPERTIES
     OUTPUT_NAME _lib_singler

lib/src/find_classic_markers.cpp

@@ -4,6 +4,7 @@
 
 #include "singlepp/singlepp.hpp"
 #include "tatami/tatami.hpp"
+#include "sanisizer/sanisizer.hpp"
 #include "pybind11/pybind11.h"
 
 #include <vector>
@@ -12,7 +13,7 @@
 
 pybind11::list find_classic_markers(uint32_t num_labels, uint32_t num_genes, const pybind11::list& reference, const pybind11::list& labels, int de_n, int nthreads) {
     size_t num_ref = reference.size();
-    if (num_ref != static_cast<size_t>(labels.size())) {
+    if (!sanisizer::is_equal(num_ref, labels.size())) {
         throw std::runtime_error("'ref' and 'labels' should have the same length");
     }
 
@@ -24,13 +25,13 @@ pybind11::list find_classic_markers(uint32_t num_labels, uint32_t num_genes, con
     for (size_t r = 0; r < num_ref; ++r) {
         auto ptr = mattress::cast(reference[r].cast<uintptr_t>())->ptr.get();
         ref_ptrs.emplace_back(ptr);
-        if (ptr->nrow() != num_genes) {
+        if (!sanisizer::is_equal(ptr->nrow(), num_genes)) {
             throw std::runtime_error("each entry of 'ref' should have number of rows equal to 'ngenes'");
         }
 
         // No copy, so it's fine to create a pointer and discard the casted array.
         auto lab = labels[r].cast<pybind11::array>();
-        if (lab.size() != static_cast<size_t>(ptr->ncol())) {
+        if (!sanisizer::is_equal(lab.size(), ptr->ncol())) {
             throw std::runtime_error("number of columns in each 'ref' should equal the length of the corresponding entry of 'labels'");
         }
 

lib/src/train_single.cpp

@@ -6,6 +6,7 @@
 #include "singlepp/singlepp.hpp"
 #include "tatami/tatami.hpp"
 #include "knncolle/knncolle.hpp"
+#include "sanisizer/sanisizer.hpp"
 #include "pybind11/pybind11.h"
 
 #include <vector>
@@ -30,9 +31,8 @@ TrainedSingleIntersectPointer train_single(
     typedef std::shared_ptr<knncolle::Builder<knncolle_py::Index, knncolle_py::MatrixValue, knncolle_py::Distance> > BuilderPointer;
     opts.trainer = BuilderPointer(BuilderPointer{}, builder.get()); // make a no-op shared pointer.
 
-    auto NR = ref->nrow();
     auto NC = ref->ncol();
-    if (static_cast<mattress::MatrixIndex>(labels.size()) != NC) {
+    if (!sanisizer::is_equal(labels.size(), NC)) {
         throw std::runtime_error("length of 'labels' is equal to the number of columns of 'ref'");
     }