fix: improve version retrieval method and enhance error handling for CacheConfig

Author: SirStig

.github/workflows/release.yml

@@ -30,13 +30,8 @@ jobs:
       - name: Check version change
         id: version-check
         run: |
-          # Get current version from package
-          CURRENT_VERSION=$(python -c "
-          import sys
-          sys.path.insert(0, 'src')
-          import yokedcache
-          print(yokedcache.__version__)
-          ")
+          # Get current version from __init__.py without importing (safer)
+          CURRENT_VERSION=$(grep '__version__ = ' src/yokedcache/__init__.py | sed 's/__version__ = "\(.*\)"/\1/')
 
           echo "Current version: $CURRENT_VERSION"
 

src/yokedcache/__init__.py

@@ -23,7 +23,18 @@ def __init__(self, *args, **kwargs):
             )
 
 
-from .config import CacheConfig
+try:
+    from .config import CacheConfig
+except ImportError:
+    # If PyYAML is not available, create a placeholder that gives helpful error
+    class CacheConfig:  # type: ignore
+        def __init__(self, *args, **kwargs):
+            raise ImportError(
+                "PyYAML is required for CacheConfig. Please install with: "
+                "pip install pyyaml>=6.0"
+            )
+
+
 from .decorators import cached, cached_dependency
 from .exceptions import (
     CacheConnectionError,

src/yokedcache/decorators.py

@@ -628,11 +628,19 @@ def sync_cached_method(*args, **kwargs):
                     self._execute_cached_query(method, args, kwargs, method_name)
                 )
             else:
-                # Running loop exists, use asyncio.create_task
-                # and wait for result
-                return loop.run_until_complete(
-                    self._execute_cached_query(method, args, kwargs, method_name)
-                )
+                # Running loop exists, we can't use run_until_complete
+                # Instead, we'll run in a new thread with its own event loop
+                import concurrent.futures
+
+                # Run the coroutine in a new thread with its own event loop
+                def _run_in_thread():
+                    return asyncio.run(
+                        self._execute_cached_query(method, args, kwargs, method_name)
+                    )
+
+                with concurrent.futures.ThreadPoolExecutor() as executor:
+                    future = executor.submit(_run_in_thread)
+                    return future.result()
 
         # Return appropriate wrapper based on whether original method is async
         if inspect.iscoroutinefunction(method):
@@ -668,7 +676,8 @@ async def _execute_cached_query(
             result = method(*args, **kwargs)
 
         # For read operations, cache the result
-        if method_name in ("query", "get", "first", "all") and result is not None:
+        read_ops = ("query", "get", "first", "all")
+        if method_name in read_ops and result is not None:
             try:
                 # Determine TTL and tags
                 actual_ttl = self._ttl or self._cache.config.default_ttl