Fix compiler warning CA1304 for API consumers.

Author: JimBobSquarePants

src/SixLabors.Fonts/FontCollection.cs

@@ -78,11 +78,11 @@ public IEnumerable<FontFamily> AddCollection(Stream stream, out IEnumerable<Font
 
     /// <inheritdoc/>
     public FontFamily Get(string name)
-        => this.Get(name, CultureInfo.InvariantCulture);
+        => this.GetByCulture(name, CultureInfo.InvariantCulture);
 
     /// <inheritdoc/>
     public bool TryGet(string name, out FontFamily family)
-        => this.TryGet(name, CultureInfo.InvariantCulture, out family);
+        => this.TryGetByCulture(name, CultureInfo.InvariantCulture, out family);
 
     /// <inheritdoc/>
     public FontFamily Add(string path, CultureInfo culture)
@@ -127,11 +127,11 @@ public IEnumerable<FontFamily> GetByCulture(CultureInfo culture)
         => this.FamiliesByCultureImpl(culture);
 
     /// <inheritdoc/>
-    public FontFamily Get(string name, CultureInfo culture)
+    public FontFamily GetByCulture(string name, CultureInfo culture)
         => this.GetImpl(name, culture);
 
     /// <inheritdoc/>
-    public bool TryGet(string name, CultureInfo culture, out FontFamily family)
+    public bool TryGetByCulture(string name, CultureInfo culture, out FontFamily family)
         => this.TryGetImpl(name, culture, out family);
 
     /// <inheritdoc/>

src/SixLabors.Fonts/IFontMetricsCollection.cs

@@ -16,11 +16,11 @@ internal interface IFontMetricsCollection : IReadOnlyFontMetricsCollection
     /// <param name="metrics">The font metrics to add.</param>
     /// <param name="culture">The culture of the font metrics to add.</param>
     /// <returns>The new <see cref="FontFamily"/>.</returns>
-    FontFamily AddMetrics(FontMetrics metrics, CultureInfo culture);
+    public FontFamily AddMetrics(FontMetrics metrics, CultureInfo culture);
 
     /// <summary>
     /// Adds the font metrics to the <see cref="IFontMetricsCollection"/>.
     /// </summary>
     /// <param name="metrics">The font metrics to add.</param>
-    void AddMetrics(FontMetrics metrics);
+    public void AddMetrics(FontMetrics metrics);
 }

src/SixLabors.Fonts/IGlyphShapingCollection.cs

@@ -13,38 +13,38 @@ internal interface IGlyphShapingCollection
     /// <summary>
     /// Gets the collection count.
     /// </summary>
-    int Count { get; }
+    public int Count { get; }
 
     /// <summary>
     /// Gets the text options used by this collection.
     /// </summary>
-    TextOptions TextOptions { get; }
+    public TextOptions TextOptions { get; }
 
     /// <summary>
     /// Gets the glyph shaping data at the specified index.
     /// </summary>
     /// <param name="index">The zero-based index of the elements to get.</param>
     /// <returns>The <see cref="GlyphShapingData"/>.</returns>
-    GlyphShapingData this[int index] { get; }
+    public GlyphShapingData this[int index] { get; }
 
     /// <summary>
     /// Adds the shaping feature to the collection which should be applied to the glyph at a specified index.
     /// </summary>
     /// <param name="index">The zero-based index of the element.</param>
     /// <param name="feature">The feature to apply.</param>
-    void AddShapingFeature(int index, TagEntry feature);
+    public void AddShapingFeature(int index, TagEntry feature);
 
     /// <summary>
     /// Enables a previously added shaping feature.
     /// </summary>
     /// <param name="index">The zero-based index of the element.</param>
     /// <param name="feature">The feature to enable.</param>
-    void EnableShapingFeature(int index, Tag feature);
+    public void EnableShapingFeature(int index, Tag feature);
 
     /// <summary>
     /// Disables a previously added shaping feature.
     /// </summary>
     /// <param name="index">The zero-based index of the element.</param>
     /// <param name="feature">The feature to disable.</param>
-    void DisableShapingFeature(int index, Tag feature);
+    public void DisableShapingFeature(int index, Tag feature);
 }

src/SixLabors.Fonts/IReadonlyFontCollection.cs

@@ -14,7 +14,7 @@ public interface IReadOnlyFontCollection
     /// Gets the collection of <see cref="FontFamily"/> in this <see cref="IReadOnlyFontCollection"/>
     /// using the invariant culture.
     /// </summary>
-    IEnumerable<FontFamily> Families { get; }
+    public IEnumerable<FontFamily> Families { get; }
 
     /// <summary>
     /// Gets the specified font family matching the invariant culture and font family name.
@@ -23,7 +23,7 @@ public interface IReadOnlyFontCollection
     /// <returns>The first <see cref="FontFamily"/> matching the given name.</returns>
     /// <exception cref="ArgumentNullException"><paramref name="name"/> is <see langword="null"/></exception>
     /// <exception cref="FontFamilyNotFoundException">The collection contains no matches.</exception>
-    FontFamily Get(string name);
+    public FontFamily Get(string name);
 
     /// <summary>
     /// Gets the specified font family matching the invariant culture and font family name.
@@ -39,15 +39,15 @@ public interface IReadOnlyFontCollection
     /// with the specified name; otherwise, <see langword="false"/>.
     /// </returns>
     /// <exception cref="ArgumentNullException"><paramref name="name"/> is <see langword="null"/></exception>
-    bool TryGet(string name, out FontFamily family);
+    public bool TryGet(string name, out FontFamily family);
 
     /// <summary>
     /// Gets the collection of <see cref="FontFamily"/> in this <see cref="FontCollection"/>
     /// using the given culture.
     /// </summary>
     /// <param name="culture">The culture of the families to return.</param>
     /// <returns>The <see cref="IEnumerable{FontFamily}"/>.</returns>
-    IEnumerable<FontFamily> GetByCulture(CultureInfo culture);
+    public IEnumerable<FontFamily> GetByCulture(CultureInfo culture);
 
     /// <summary>
     /// Gets the specified font family matching the given culture and font family name.
@@ -57,7 +57,7 @@ public interface IReadOnlyFontCollection
     /// <returns>The first <see cref="FontFamily"/> matching the given name.</returns>
     /// <exception cref="ArgumentNullException"><paramref name="name"/> is <see langword="null"/></exception>
     /// <exception cref="FontFamilyNotFoundException">The collection contains no matches.</exception>
-    FontFamily Get(string name, CultureInfo culture);
+    public FontFamily GetByCulture(string name, CultureInfo culture);
 
     /// <summary>
     /// Gets the specified font family matching the given culture and font family name.
@@ -74,5 +74,5 @@ public interface IReadOnlyFontCollection
     /// with the specified name; otherwise, <see langword="false"/>.
     /// </returns>
     /// <exception cref="ArgumentNullException"><paramref name="name"/> is <see langword="null"/></exception>
-    bool TryGet(string name, CultureInfo culture, out FontFamily family);
+    public bool TryGetByCulture(string name, CultureInfo culture, out FontFamily family);
 }

src/SixLabors.Fonts/IReadonlyFontMetricsCollection.cs

@@ -28,7 +28,7 @@ internal interface IReadOnlyFontMetricsCollection
     /// with the specified name; otherwise, <see langword="false"/>.
     /// </returns>
     /// <exception cref="ArgumentNullException"><paramref name="name"/> is <see langword="null"/></exception>
-    bool TryGetMetrics(string name, CultureInfo culture, FontStyle style, [NotNullWhen(true)] out FontMetrics? metrics);
+    public bool TryGetMetrics(string name, CultureInfo culture, FontStyle style, [NotNullWhen(true)] out FontMetrics? metrics);
 
     /// <summary>
     /// Gets the collection of available font metrics for a given culture and font family name.
@@ -37,7 +37,7 @@ internal interface IReadOnlyFontMetricsCollection
     /// <param name="culture">The culture to use when searching for a match.</param>
     /// <returns>The <see cref="IEnumerable{FontMetrics}"/>.</returns>
     /// <exception cref="ArgumentNullException"><paramref name="name"/> is <see langword="null"/></exception>
-    IEnumerable<FontMetrics> GetAllMetrics(string name, CultureInfo culture);
+    public IEnumerable<FontMetrics> GetAllMetrics(string name, CultureInfo culture);
 
     /// <summary>
     /// Gets the collection of available font styles for a given culture and font family name.
@@ -46,8 +46,8 @@ internal interface IReadOnlyFontMetricsCollection
     /// <param name="culture">The culture to use when searching for a match.</param>
     /// <returns>The <see cref="IEnumerable{FontStyle}"/>.</returns>
     /// <exception cref="ArgumentNullException"><paramref name="name"/> is <see langword="null"/></exception>
-    IEnumerable<FontStyle> GetAllStyles(string name, CultureInfo culture);
+    public IEnumerable<FontStyle> GetAllStyles(string name, CultureInfo culture);
 
     /// <inheritdoc cref="IEnumerable{T}.GetEnumerator"/>
-    IEnumerator<FontMetrics> GetEnumerator();
+    public IEnumerator<FontMetrics> GetEnumerator();
 }

src/SixLabors.Fonts/SystemFontCollection.cs

@@ -108,7 +108,7 @@ public SystemFontCollection()
     public IEnumerable<string> SearchDirectories => this.searchDirectories;
 
     /// <inheritdoc/>
-    public FontFamily Get(string name) => this.Get(name, CultureInfo.InvariantCulture);
+    public FontFamily Get(string name) => this.GetByCulture(name, CultureInfo.InvariantCulture);
 
     /// <inheritdoc/>
     public bool TryGet(string name, out FontFamily family)
@@ -119,12 +119,12 @@ public IEnumerable<FontFamily> GetByCulture(CultureInfo culture)
         => this.collection.GetByCulture(culture);
 
     /// <inheritdoc/>
-    public FontFamily Get(string name, CultureInfo culture)
-        => this.collection.Get(name, culture);
+    public FontFamily GetByCulture(string name, CultureInfo culture)
+        => this.collection.GetByCulture(name, culture);
 
     /// <inheritdoc/>
-    public bool TryGet(string name, CultureInfo culture, out FontFamily family)
-        => this.collection.TryGet(name, culture, out family);
+    public bool TryGetByCulture(string name, CultureInfo culture, out FontFamily family)
+        => this.collection.TryGetByCulture(name, culture, out family);
 
     /// <inheritdoc/>
     bool IReadOnlyFontMetricsCollection.TryGetMetrics(string name, CultureInfo culture, FontStyle style, [NotNullWhen(true)] out FontMetrics? metrics)

src/SixLabors.Fonts/SystemFonts.cs

@@ -23,7 +23,7 @@ public static class SystemFonts
     public static IEnumerable<FontFamily> Families => Collection.Families;
 
     /// <inheritdoc cref="IReadOnlyFontCollection.Get(string)"/>
-    public static FontFamily Get(string name) => Get(name, CultureInfo.InvariantCulture);
+    public static FontFamily Get(string name) => GetByCulture(name, CultureInfo.InvariantCulture);
 
     /// <inheritdoc cref="IReadOnlyFontCollection.TryGet(string, out FontFamily)" />
     public static bool TryGet(string fontFamily, out FontFamily family)
@@ -52,13 +52,13 @@ public static Font CreateFont(string name, float size, FontStyle style)
     public static IEnumerable<FontFamily> GetByCulture(CultureInfo culture)
         => Collection.GetByCulture(culture);
 
-    /// <inheritdoc cref="IReadOnlyFontCollection.Get(string, CultureInfo)" />
-    public static FontFamily Get(string fontFamily, CultureInfo culture)
-        => Collection.Get(fontFamily, culture);
+    /// <inheritdoc cref="IReadOnlyFontCollection.GetByCulture(string, CultureInfo)" />
+    public static FontFamily GetByCulture(string fontFamily, CultureInfo culture)
+        => Collection.GetByCulture(fontFamily, culture);
 
-    /// <inheritdoc cref="IReadOnlyFontCollection.TryGet(string, CultureInfo, out FontFamily)" />
-    public static bool TryGet(string fontFamily, CultureInfo culture, out FontFamily family)
-        => Collection.TryGet(fontFamily, culture, out family);
+    /// <inheritdoc cref="IReadOnlyFontCollection.TryGetByCulture(string, CultureInfo, out FontFamily)" />
+    public static bool TryGetByCulture(string fontFamily, CultureInfo culture, out FontFamily family)
+        => Collection.TryGetByCulture(fontFamily, culture, out family);
 
     /// <summary>
     /// Create a new instance of the <see cref="Font"/> for the named font family with regular styling.
@@ -68,7 +68,7 @@ public static bool TryGet(string fontFamily, CultureInfo culture, out FontFamily
     /// <param name="size">The size of the font in PT units.</param>
     /// <returns>The new <see cref="Font"/>.</returns>
     public static Font CreateFont(string name, CultureInfo culture, float size)
-        => Collection.Get(name, culture).CreateFont(size);
+        => Collection.GetByCulture(name, culture).CreateFont(size);
 
     /// <summary>
     /// Create a new instance of the <see cref="Font"/> for the named font family.
@@ -79,5 +79,5 @@ public static Font CreateFont(string name, CultureInfo culture, float size)
     /// <param name="style">The font style.</param>
     /// <returns>The new <see cref="Font"/>.</returns>
     public static Font CreateFont(string name, CultureInfo culture, float size, FontStyle style)
-        => Collection.Get(name, culture).CreateFont(size, style);
+        => Collection.GetByCulture(name, culture).CreateFont(size, style);
 }

tests/SixLabors.Fonts.Tests/SystemFontCollectionTests.cs

@@ -34,9 +34,9 @@ public void SystemFonts_CanGetFont_ByCulture()
         FontFamily family = SystemFonts.Families.First();
 
         Assert.False(family == default);
-        Assert.Equal(family, SystemFonts.Get(family.Name, family.Culture));
+        Assert.Equal(family, SystemFonts.GetByCulture(family.Name, family.Culture));
 
-        SystemFonts.TryGet(family.Name, family.Culture, out FontFamily family2);
+        SystemFonts.TryGetByCulture(family.Name, family.Culture, out FontFamily family2);
 
         Assert.Equal(family, family2);
         Assert.Contains(family, SystemFonts.GetByCulture(family.Culture));