Do not use pedantic hinting.

Author: JimBobSquarePants

src/SixLabors.Fonts/Tables/TrueType/Hinting/TrueTypeInterpreter.cs

@@ -66,7 +66,7 @@ internal class TrueTypeInterpreter
     private const int MaxCallStack = 128;
     private const float Epsilon = 0.000001F;
 
-    private readonly List<OpCode> debugList = new();
+    private readonly List<OpCode> debugList = [];
 
     public TrueTypeInterpreter(int maxStack, int maxStorage, int maxFunctions, int maxInstructionDefs, int maxTwilightPoints)
     {
@@ -77,7 +77,7 @@ public TrueTypeInterpreter(int maxStack, int maxStorage, int maxFunctions, int m
         this.state = default;
         this.cvtState = default;
         this.twilight = new Zone(maxTwilightPoints, isTwilight: true);
-        this.controlValueTable = Array.Empty<float>();
+        this.controlValueTable = [];
         this.contours = Array.Empty<ushort>();
     }
 
@@ -97,7 +97,6 @@ public void SetControlValueTable(short[]? cvt, float scale, float ppem, byte[]?
                 this.controlValueTable = new float[cvt.Length];
             }
 
-            // TODO: How about SIMD here? Will the JIT vectorize this?
             for (int i = 0; i < cvt.Length; i++)
             {
                 this.controlValueTable[i] = cvt[i] * scale;
@@ -227,15 +226,15 @@ private void Execute(StackInstructionStream stream, bool inFunction, bool allowF
                 // ==== STORAGE MANAGEMENT ====
                 case OpCode.RS:
                 {
-                    int loc = CheckIndex(this.stack.Pop(), this.storage.Length);
+                    int loc = IndexOrZero(this.stack.Pop(), this.storage.Length);
                     this.stack.Push(this.storage[loc]);
                 }
 
                 break;
                 case OpCode.WS:
                 {
                     int value = this.stack.Pop();
-                    int loc = CheckIndex(this.stack.Pop(), this.storage.Length);
+                    int loc = IndexOrZero(this.stack.Pop(), this.storage.Length);
                     this.storage[loc] = value;
                 }
 
@@ -245,15 +244,15 @@ private void Execute(StackInstructionStream stream, bool inFunction, bool allowF
                 case OpCode.WCVTP:
                 {
                     float value = this.stack.PopFloat();
-                    int loc = CheckIndex(this.stack.Pop(), this.controlValueTable.Length);
+                    int loc = IndexOrZero(this.stack.Pop(), this.controlValueTable.Length);
                     this.controlValueTable[loc] = value;
                 }
 
                 break;
                 case OpCode.WCVTF:
                 {
                     int value = this.stack.Pop();
-                    int loc = CheckIndex(this.stack.Pop(), this.controlValueTable.Length);
+                    int loc = IndexOrZero(this.stack.Pop(), this.controlValueTable.Length);
                     this.controlValueTable[loc] = value * this.scale;
                 }
 
@@ -316,7 +315,7 @@ private void Execute(StackInstructionStream stream, bool inFunction, bool allowF
                 {
                     int y = this.stack.Pop();
                     int x = this.stack.Pop();
-                    var vec = Vector2.Normalize(new Vector2(F2Dot14ToFloat(x), F2Dot14ToFloat(y)));
+                    Vector2 vec = Vector2.Normalize(new Vector2(F2Dot14ToFloat(x), F2Dot14ToFloat(y)));
                     if (opcode == OpCode.SFVFS)
                     {
                         this.state.Freedom = vec;
@@ -1379,8 +1378,8 @@ private void Execute(StackInstructionStream stream, bool inFunction, bool allowF
                             amount *= 1 << (6 - this.state.DeltaShift);
 
                             // update the CVT
-                            CheckIndex(cvtIndex, this.controlValueTable.Length);
-                            this.controlValueTable[cvtIndex] += F26Dot6ToFloat(amount);
+                            int loc = IndexOrZero(cvtIndex, this.controlValueTable.Length);
+                            this.controlValueTable[loc] += F26Dot6ToFloat(amount);
                         }
                     }
                 }
@@ -1504,13 +1503,9 @@ private void Execute(StackInstructionStream stream, bool inFunction, bool allowF
         }
     }
 
-    private static int CheckIndex(int index, int length)
-    {
-        Guard.MustBeBetweenOrEqualTo(index, 0, length - 1, nameof(index));
-        return index;
-    }
+    private static int IndexOrZero(int index, int length) => (uint)index < (uint)length ? index : 0;
 
-    private float ReadCvt() => this.controlValueTable[CheckIndex(this.stack.Pop(), this.controlValueTable.Length)];
+    private float ReadCvt() => this.controlValueTable[IndexOrZero(this.stack.Pop(), this.controlValueTable.Length)];
 
     private void OnVectorsUpdated()
     {
@@ -2474,7 +2469,7 @@ public Zone(ControlPoint[] controlPoints, bool isTwilight)
             this.IsTwilight = isTwilight;
             this.Current = controlPoints;
 
-            var original = new ControlPoint[controlPoints.Length];
+            ControlPoint[] original = new ControlPoint[controlPoints.Length];
             controlPoints.AsSpan().CopyTo(original);
             this.Original = original;
             this.TouchState = new TouchState[controlPoints.Length];

tests/Images/ReferenceOutput/Test_Issue_493_MgOpenCanonic-.png

@@ -0,0 +1,63 @@
+// Copyright (c) Six Labors.
+// Licensed under the Six Labors Split License.
+
+namespace SixLabors.Fonts.Tests.Issues;
+
+public class Issues_493
+{
+    [Fact]
+    public void Test_Issue_493_Ogham()
+    {
+        const string text =
+            """
+            Ogham
+            ᚛ᚐᚅᚋᚐᚇᚐᚅᚈᚐ᚜
+            """;
+
+        FontCollection fontCollection = new();
+        string name = fontCollection.Add(TestFonts.NotoSansOghamRegular).Name;
+
+        FontFamily mainFontFamily = fontCollection.Get(name);
+        Font mainFont = mainFontFamily.CreateFont(30, FontStyle.Regular);
+
+        TextOptions options = new(mainFont) { HintingMode = HintingMode.Standard };
+
+        TextLayoutTestUtilities.TestLayout(text, options);
+    }
+
+    [Fact]
+    public void Test_Issue_493_Runic()
+    {
+        const string text =
+            """
+            Runic
+            ᚦᛖᚱᛅᛈᛁᛑᛒᚱᚢᚾᚠᛅᚢᛋ
+            """;
+
+        FontCollection fontCollection = new();
+        string name = fontCollection.Add(TestFonts.NotoSansRunicRegular).Name;
+
+        FontFamily mainFontFamily = fontCollection.Get(name);
+        Font mainFont = mainFontFamily.CreateFont(30, FontStyle.Regular);
+
+        TextOptions options = new(mainFont) { HintingMode = HintingMode.Standard };
+
+        TextLayoutTestUtilities.TestLayout(text, options);
+    }
+
+    [Fact]
+    public void Test_Issue_493_MgOpenCanonic()
+    {
+        const string text = "the quick brown fox jumps over the lazy dog";
+
+        FontCollection fontCollection = new();
+        string name = fontCollection.Add(TestFonts.NotoSansRunicRegular).Name;
+
+        FontFamily mainFontFamily = fontCollection.Get(name);
+        Font mainFont = mainFontFamily.CreateFont(30, FontStyle.Regular);
+
+        TextOptions options = new(mainFont) { HintingMode = HintingMode.Standard };
+
+        TextLayoutTestUtilities.TestLayout(text, options);
+    }
+}

tests/Images/ReferenceOutput/Test_Issue_493_Ogham-.png

@@ -305,6 +305,12 @@ public static class TestFonts
 
     public static string MyanmarSansRegular => GetFullPath("NotoSansMyanmar-Regular.ttf");
 
+    public static string NotoSansOghamRegular => GetFullPath("NotoSansOgham-Regular.ttf");
+
+    public static string NotoSansRunicRegular => GetFullPath("NotoSansRunic-Regular.ttf");
+
+    public static string MgOpenCanonicRegular => GetFullPath("mgopencanonicaregular.ttf");
+
     public static Stream TwemojiMozillaData() => OpenStream(TwemojiMozillaFile);
 
     public static Stream SegoeuiEmojiData() => OpenStream(SegoeuiEmojiFile);