Skip to content

Commit 337d799

Browse files
Update test refs and dependencies
1 parent 359a348 commit 337d799

17 files changed

+38
-22
lines changed

src/ImageSharp.Drawing/ImageSharp.Drawing.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<None Include="..\..\shared-infrastructure\branding\icons\imagesharp.drawing\sixlabors.imagesharp.drawing.128.png" Pack="true" PackagePath="" />
1919
</ItemGroup>
2020
<ItemGroup>
21-
<PackageReference Include="SixLabors.Fonts" Version="1.0.0-beta19.12" />
21+
<PackageReference Include="SixLabors.Fonts" Version="1.0.0-beta19.13" />
2222
<PackageReference Include="SixLabors.ImageSharp" Version="2.1.3" />
2323
</ItemGroup>
2424
<Import Project="..\..\shared-infrastructure\src\SharedInfrastructure\SharedInfrastructure.projitems" Label="Shared" />

tests/ImageSharp.Drawing.Tests/Drawing/Text/DrawTextOnImageTests.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
using System;
55
using System.Collections.Generic;
6-
using System.IO;
76
using System.Linq;
87
using System.Numerics;
98
using System.Text;
@@ -813,7 +812,8 @@ public void CanFillTextVertical<TPixel>(TestImageProvider<TPixel> provider)
813812

814813
IPathCollection glyphs = TextBuilder.GenerateGlyphs(text, textOptions);
815814

816-
DrawingOptions options = new() { ShapeOptions = new() { IntersectionRule = IntersectionRule.Nonzero } };
815+
// TODO: This still leaves some holes when overlaying the text (CFF NotoSansKRRegular only). We need to fix this.
816+
DrawingOptions options = new() { ShapeOptions = new() { IntersectionRule = IntersectionRule.NonZero } };
817817

818818
provider.RunValidatingProcessorTest(
819819
c => c.Fill(Color.White).Fill(options, Color.Black, glyphs),
@@ -838,7 +838,9 @@ public void CanFillTextVerticalMixed<TPixel>(TestImageProvider<TPixel> provider)
838838
};
839839

840840
IPathCollection glyphs = TextBuilder.GenerateGlyphs(text, textOptions);
841-
DrawingOptions options = new() { ShapeOptions = new() { IntersectionRule = IntersectionRule.Nonzero } };
841+
842+
// TODO: This still leaves some holes when overlaying the text (CFF NotoSansKRRegular only). We need to fix this.
843+
DrawingOptions options = new() { ShapeOptions = new() { IntersectionRule = IntersectionRule.NonZero } };
842844

843845
provider.RunValidatingProcessorTest(
844846
c => c.Fill(Color.White).Fill(options, Color.Black, glyphs),

tests/ImageSharp.Drawing.Tests/TestFonts.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,7 @@ public static class TestFonts
2424
public const string NettoOffc = "NettoOffc.ttf";
2525

2626
public const string NotoSansKRRegular = "NotoSansKR-Regular.otf";
27+
28+
public const string NotoSerifKRRegular = "NotoSerifKR-Regular.otf";
2729
}
2830
}
7.07 MB
Binary file not shown.
Lines changed: 2 additions & 2 deletions
Loading
Lines changed: 2 additions & 2 deletions
Loading
Lines changed: 3 additions & 0 deletions
Loading
Lines changed: 3 additions & 0 deletions
Loading
Lines changed: 3 additions & 0 deletions
Loading
Lines changed: 3 additions & 0 deletions
Loading

0 commit comments

Comments
 (0)