Resolve review

Author: stefannikolei

src/ImageSharp.Web.Providers.AWS/AmazonS3ClientFactory.cs

@@ -32,7 +32,7 @@ public static AmazonS3Client CreateClient(IAWSS3BucketClientOptions options)
         else if (!string.IsNullOrWhiteSpace(options.AccessKey))
         {
             // AccessSecret can be empty.
-            Guard.NotNullOrWhiteSpace(options.Region!, nameof(options.Region));
+            Guard.NotNullOrWhiteSpace(options.Region, nameof(options.Region));
             RegionEndpoint region = RegionEndpoint.GetBySystemName(options.Region);
             AmazonS3Config config = new() { RegionEndpoint = region, UseAccelerateEndpoint = options.UseAccelerateEndpoint };
             SetTimeout(config, options.Timeout);

src/ImageSharp.Web.Providers.AWS/Caching/AWSS3StorageCacheOptions.cs

@@ -9,23 +9,23 @@ namespace SixLabors.ImageSharp.Web.Caching.AWS;
 public class AWSS3StorageCacheOptions : IAWSS3BucketClientOptions
 {
     /// <inheritdoc/>
-    public string? Region { get; set; }
+    public string? Region { get; init; }
 
     /// <inheritdoc/>
-    public string BucketName { get; set; } = null!;
+    public string BucketName { get; init; } = null!;
 
     /// <inheritdoc/>
-    public string? AccessKey { get; set; }
+    public string? AccessKey { get; init; }
 
     /// <inheritdoc/>
-    public string? AccessSecret { get; set; }
+    public string? AccessSecret { get; init; }
 
     /// <inheritdoc/>
-    public string? Endpoint { get; set; }
+    public string? Endpoint { get; init; }
 
     /// <inheritdoc/>
-    public bool UseAccelerateEndpoint { get; set; }
+    public bool UseAccelerateEndpoint { get; init; }
 
     /// <inheritdoc/>
-    public TimeSpan? Timeout { get; set; }
+    public TimeSpan? Timeout { get; init; }
 }

src/ImageSharp.Web.Providers.AWS/IAWSS3BucketClientOptions.cs

@@ -9,44 +9,44 @@ namespace SixLabors.ImageSharp.Web;
 internal interface IAWSS3BucketClientOptions
 {
     /// <summary>
-    /// Gets or sets the AWS region endpoint (us-east-1/us-west-1/ap-southeast-2).
+    /// Gets the AWS region endpoint (us-east-1/us-west-1/ap-southeast-2).
     /// </summary>
-    string? Region { get; set; }
+    string? Region { get; init; }
 
     /// <summary>
-    /// Gets or sets the AWS bucket name.
+    /// Gets the AWS bucket name.
     /// </summary>
-    string BucketName { get; set; }
+    string BucketName { get; init; }
 
     /// <summary>
-    /// Gets or sets the AWS key - Can be used to override keys provided by the environment.
+    /// Gets the AWS key - Can be used to override keys provided by the environment.
     /// If deploying inside an EC2 instance AWS keys will already be available via environment
     /// variables and don't need to be specified. Follow AWS best security practices on  <see href="https://docs.aws.amazon.com/general/latest/gr/aws-access-keys-best-practices.html"/>.
     /// </summary>
-    string? AccessKey { get; set; }
+    string? AccessKey { get; init; }
 
     /// <summary>
-    /// Gets or sets the AWS secret - Can be used to override keys provided by the environment.
+    /// Gets the AWS endpoint - used to override the default service endpoint.
     /// If deploying inside an EC2 instance AWS keys will already be available via environment
     /// variables and don't need to be specified. Follow AWS best security practices on  <see href="https://docs.aws.amazon.com/general/latest/gr/aws-access-keys-best-practices.html"/>.
     /// </summary>
-    string? AccessSecret { get; set; }
+    string? AccessSecret { get; init; }
 
     /// <summary>
-    /// Gets or sets the AWS endpoint - used for testing to over region endpoint allowing it
+    /// Gets the AWS endpoint - used for testing to over region endpoint allowing it
     /// to be set to localhost.
     /// </summary>
-    string? Endpoint { get; set; }
+    string? Endpoint { get; init; }
 
     /// <summary>
-    /// Gets or sets a value indicating whether the S3 accelerate endpoint is used.
+    /// Gets a value indicating whether the S3 accelerate endpoint is used.
     /// The feature must be enabled on the bucket. Follow AWS instruction on <see href="https://docs.aws.amazon.com/AmazonS3/latest/userguide/transfer-acceleration.html"/>.
     /// </summary>
-    bool UseAccelerateEndpoint { get; set; }
+    bool UseAccelerateEndpoint { get; init; }
 
     /// <summary>
-    /// Gets or sets a value indicating the timeout for the S3 client.
+    /// Gets a value indicating the timeout for the S3 client.
     /// If the value is set, the value is assigned to the Timeout property of the HttpWebRequest/HttpClient object used to send requests.
     /// </summary>
-    TimeSpan? Timeout { get; set; }
+    TimeSpan? Timeout { get; init; }
 }

src/ImageSharp.Web.Providers.AWS/Providers/AWSS3StorageImageProviderOptions.cs

@@ -20,23 +20,23 @@ public class AWSS3StorageImageProviderOptions
 public class AWSS3BucketClientOptions : IAWSS3BucketClientOptions
 {
     /// <inheritdoc/>
-    public string? Region { get; set; }
+    public string? Region { get; init; }
 
     /// <inheritdoc/>
-    public string BucketName { get; set; } = null!;
+    public string BucketName { get; init; } = null!;
 
     /// <inheritdoc/>
-    public string? AccessKey { get; set; }
+    public string? AccessKey { get; init; }
 
     /// <inheritdoc/>
-    public string? AccessSecret { get; set; }
+    public string? AccessSecret { get; init; }
 
     /// <inheritdoc/>
-    public string? Endpoint { get; set; }
+    public string? Endpoint { get; init; }
 
     /// <inheritdoc/>
-    public bool UseAccelerateEndpoint { get; set; }
+    public bool UseAccelerateEndpoint { get; init; }
 
     /// <inheritdoc/>
-    public TimeSpan? Timeout { get; set; }
+    public TimeSpan? Timeout { get; init; }
 }