Address feedback

Author: JimBobSquarePants

src/ImageSharp.Web.Providers.AWS/Caching/AWSS3StorageCache.cs

@@ -126,7 +126,7 @@ private static async Task<PutBucketResponse> CreateIfNotExistsAsync(
         /// <summary>
         /// <see href="https://github.com/aspnet/AspNetIdentity/blob/b7826741279450c58b230ece98bd04b4815beabf/src/Microsoft.AspNet.Identity.Core/AsyncHelper.cs"/>
         /// </summary>
-        internal static class AsyncHelper
+        private static class AsyncHelper
         {
             private static readonly TaskFactory TaskFactory
                 = new(

src/ImageSharp.Web/CaseHandlingUriBuilder.cs

@@ -159,7 +159,7 @@ public static string Encode(CaseHandling handling, Uri uri)
                 Uri faux = new(FallbackBaseUri, uri);
                 return BuildRelative(
                     handling,
-                    pathBase: PathString.FromUriComponent(faux),
+                    path: PathString.FromUriComponent(faux),
                     query: QueryString.FromUriComponent(faux));
             }
         }
@@ -210,7 +210,7 @@ private static void InitializeAbsoluteUriString(Span<char> buffer, (bool Lower,
 
             if (uriParts.Scheme.Length > 0)
             {
-                index = CopyTextToBuffer(buffer, index, uriParts.Scheme.AsSpan());
+                index = CopyTextToBufferLowerInvariant(buffer, index, uriParts.Scheme.AsSpan());
                 index = CopyTextToBuffer(buffer, index, Uri.SchemeDelimiter.AsSpan());
             }
 

src/ImageSharp.Web/Commands/QueryCollectionRequestParser.cs

@@ -23,7 +23,7 @@ public CommandCollection ParseRequestCommands(HttpContext context)
             }
 
             CommandCollection transformed = new();
-            foreach (KeyValuePair<string, StringValues> pair in context.Request.Query)
+            foreach (KeyValuePair<string, StringValues> pair in query)
             {
                 // Use the indexer for both set and query. This replaces any previously parsed values.
                 transformed[pair.Key] = pair.Value[pair.Value.Count - 1];

src/ImageSharp.Web/ImageSharpRequestAuthorizationUtilities.cs

@@ -231,25 +231,14 @@ public async Task<string> ComputeHMACAsync(HttpContext context, CommandHandling
         /// <summary>
         /// Compute a Hash-based Message Authentication Code (HMAC) for request authentication.
         /// </summary>
+        /// <remarks>
+        /// This method is only called by the middleware and only if required.
+        /// As such, standard checks are avoided.
+        /// </remarks>
         /// <param name="context">Contains information about the current image request and parsed commands.</param>
-        /// <param name="handling">The command collection handling.</param>
         /// <returns>The computed HMAC.</returns>
-        internal async Task<string> ComputeHMACAsync(ImageCommandContext context, CommandHandling handling)
-        {
-            byte[] secret = this.options.HMACSecretKey;
-            if (secret is null || secret.Length == 0)
-            {
-                return null;
-            }
-
-            CommandCollection commands = this.requestParser.ParseRequestCommands(context.Context);
-            if (handling == CommandHandling.Sanitize)
-            {
-                this.StripUnknownCommands(commands);
-            }
-
-            return await this.options.OnComputeHMACAsync(context, secret);
-        }
+        internal Task<string> ComputeHMACAsync(ImageCommandContext context)
+            => this.options.OnComputeHMACAsync(context, this.options.HMACSecretKey);
 
         private static void ToComponents(
             Uri uri,

src/ImageSharp.Web/Middleware/ImageSharpMiddleware.cs

@@ -236,7 +236,7 @@ private async Task Invoke(HttpContext httpContext, bool retry)
                 // Key generation uses string.Create under the hood with very low allocation so should be good enough as a cache key.
                 hmac = await HMACTokenLru.GetOrAddAsync(
                     httpContext.Request.GetEncodedUrl(),
-                    _ => this.authorizationUtilities.ComputeHMACAsync(imageCommandContext, CommandHandling.None));
+                    _ => this.authorizationUtilities.ComputeHMACAsync(imageCommandContext));
             }
 
             await this.options.OnParseCommandsAsync.Invoke(imageCommandContext);