Skip to content

Commit d0b2e10

Browse files
Dispose of requests/responses
1 parent f646512 commit d0b2e10

File tree

2 files changed

+20
-0
lines changed

2 files changed

+20
-0
lines changed

tests/ImageSharp.Web.Tests/Processing/AzureBlobStorageCacheServerTests.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ public async Task CanProcessAndResolveImage(string url)
4444
Assert.Equal(Width, image.Width);
4545
Assert.Equal(format, actual.Format);
4646

47+
response.Dispose();
48+
4749
// Cached Response
4850
response = await this.HttpClient.GetAsync(url + Command);
4951

@@ -58,6 +60,8 @@ public async Task CanProcessAndResolveImage(string url)
5860
Assert.Equal(Width, cached.Width);
5961
Assert.Equal(format, actual.Format);
6062

63+
response.Dispose();
64+
6165
// 304 response
6266
var request = new HttpRequestMessage
6367
{
@@ -73,6 +77,9 @@ public async Task CanProcessAndResolveImage(string url)
7377
Assert.Equal(0, response.Content.Headers.ContentLength);
7478
Assert.Equal(format.DefaultMimeType, response.Content.Headers.ContentType.MediaType);
7579

80+
request.Dispose();
81+
response.Dispose();
82+
7683
// 412 response
7784
request = new HttpRequestMessage
7885
{
@@ -86,6 +93,9 @@ public async Task CanProcessAndResolveImage(string url)
8693

8794
Assert.Equal(HttpStatusCode.PreconditionFailed, response.StatusCode);
8895
Assert.Equal(0, response.Content.Headers.ContentLength);
96+
97+
request.Dispose();
98+
response.Dispose();
8999
}
90100
}
91101
}

tests/ImageSharp.Web.Tests/Processing/PhysicalFileSystemCacheServerTests.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ public async Task CanProcessAndResolveImage(string url)
4444
Assert.Equal(Width, image.Width);
4545
Assert.Equal(format, actual.Format);
4646

47+
response.Dispose();
48+
4749
// Cached Response
4850
response = await this.HttpClient.GetAsync(url + Command);
4951

@@ -58,6 +60,8 @@ public async Task CanProcessAndResolveImage(string url)
5860
Assert.Equal(Width, cached.Width);
5961
Assert.Equal(format, actual.Format);
6062

63+
response.Dispose();
64+
6165
// 304 response
6266
var request = new HttpRequestMessage
6367
{
@@ -73,6 +77,9 @@ public async Task CanProcessAndResolveImage(string url)
7377
Assert.Equal(0, response.Content.Headers.ContentLength);
7478
Assert.Equal(format.DefaultMimeType, response.Content.Headers.ContentType.MediaType);
7579

80+
request.Dispose();
81+
response.Dispose();
82+
7683
// 412 response
7784
request = new HttpRequestMessage
7885
{
@@ -86,6 +93,9 @@ public async Task CanProcessAndResolveImage(string url)
8693

8794
Assert.Equal(HttpStatusCode.PreconditionFailed, response.StatusCode);
8895
Assert.Equal(0, response.Content.Headers.ContentLength);
96+
97+
request.Dispose();
98+
response.Dispose();
8999
}
90100
}
91101
}

0 commit comments

Comments
 (0)