pass only "pinnable: this" to MemoryHandle

antonfirsov · antonfirsov · commit 289e9f8800c5 · 2021-08-27T17:49:11.000+02:00
diff --git a/src/ImageSharp/Memory/Allocators/Internals/ManagedBufferBase.cs b/src/ImageSharp/Memory/Allocators/Internals/ManagedBufferBase.cs
@@ -24,7 +24,9 @@ public override unsafe MemoryHandle Pin(int elementIndex = 0)
             }
 
             void* ptr = (void*)this.pinHandle.AddrOfPinnedObject();
-            return new MemoryHandle(ptr, this.pinHandle, this);
+
+            // We should only pass pinnable:this, when GCHandle lifetime is managed by the MemoryManager<T> instance.
+            return new MemoryHandle(ptr, pinnable: this);
         }
 
         /// <inheritdoc />

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,9 @@ public override unsafe MemoryHandle Pin(int elementIndex = 0)`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`void* ptr = (void*)this.pinHandle.AddrOfPinnedObject();`
`27`		`- return new MemoryHandle(ptr, this.pinHandle, this);`
	`27`	`+`
	`28`	`+ // We should only pass pinnable:this, when GCHandle lifetime is managed by the MemoryManager<T> instance.`
	`29`	`+ return new MemoryHandle(ptr, pinnable: this);`
`28`	`30`	`}`
`29`	`31`
`30`	`32`	`/// <inheritdoc />`