fix allocation (CA2014)

IldarKhayrutdinov · IldarKhayrutdinov · commit 40b7be804173 · 2025-01-27T08:09:59.000+03:00
diff --git a/src/ImageSharp/Metadata/Profiles/Exif/ExifReader.cs b/src/ImageSharp/Metadata/Profiles/Exif/ExifReader.cs
@@ -191,10 +191,7 @@ protected void ReadSubIfd(List<IExifValue> values)
         {
             do
             {
-                int sz = this.subIfds.Count;
-                Span<ulong> buf = sz <= 256 ? stackalloc ulong[sz] : new ulong[sz];
-
-                this.subIfds.CopyTo(buf);
+                ulong[] buf = [.. this.subIfds];
                 this.subIfds.Clear();
                 foreach (ulong subIfdOffset in buf)
                 {
@@ -456,6 +453,7 @@ private void ReadValue64(List<IExifValue> values, Span<byte> offsetBuffer)
             ExifTagValue.TileByteCounts => new ExifLong8Array(ExifTagValue.TileByteCounts),
             _ => ExifValues.Create(tag) ?? ExifValues.Create(tag, dataType, numberOfComponents),
         };
+
         if (exifValue is null)
         {
             this.AddInvalidTag(new UnkownExifTag(tag));

Original file line number	Diff line number	Diff line change
`@@ -191,10 +191,7 @@ protected void ReadSubIfd(List<IExifValue> values)`
`191`	`191`	`{`
`192`	`192`	`do`
`193`	`193`	`{`
`194`		`- int sz = this.subIfds.Count;`
`195`		`- Span<ulong> buf = sz <= 256 ? stackalloc ulong[sz] : new ulong[sz];`
`196`		`-`
`197`		`- this.subIfds.CopyTo(buf);`
	`194`	`+ ulong[] buf = [.. this.subIfds];`
`198`	`195`	`this.subIfds.Clear();`
`199`	`196`	`foreach (ulong subIfdOffset in buf)`
`200`	`197`	`{`
`@@ -456,6 +453,7 @@ private void ReadValue64(List<IExifValue> values, Span<byte> offsetBuffer)`
`456`	`453`	`ExifTagValue.TileByteCounts => new ExifLong8Array(ExifTagValue.TileByteCounts),`
`457`	`454`	`_ => ExifValues.Create(tag) ?? ExifValues.Create(tag, dataType, numberOfComponents),`
`458`	`455`	`};`
	`456`	`+`
`459`	`457`	`if (exifValue is null)`
`460`	`458`	`{`
`461`	`459`	`this.AddInvalidTag(new UnkownExifTag(tag));`