Skip to content

Commit c8eab78

Browse files
committed
Rename DefaultImageAnimated to AnimateRootFrame
1 parent 8480139 commit c8eab78

File tree

6 files changed

+14
-14
lines changed

6 files changed

+14
-14
lines changed

src/ImageSharp/Formats/Png/PngDecoderCore.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ public Image<TPixel> Decode<TPixel>(BufferedReadStream stream, CancellationToken
248248

249249
break;
250250
case PngChunkType.Data:
251-
pngMetadata.DefaultImageAnimated = currentFrameControl != null;
251+
pngMetadata.AnimateRootFrame = currentFrameControl != null;
252252
currentFrameControl ??= new((uint)this.header.Width, (uint)this.header.Height);
253253
if (image is null)
254254
{
@@ -265,7 +265,7 @@ public Image<TPixel> Decode<TPixel>(BufferedReadStream stream, CancellationToken
265265
this.ReadNextDataChunk,
266266
currentFrameControl.Value,
267267
cancellationToken);
268-
if (pngMetadata.DefaultImageAnimated)
268+
if (pngMetadata.AnimateRootFrame)
269269
{
270270
previousFrame = currentFrame;
271271
previousFrameControl = currentFrameControl;

src/ImageSharp/Formats/Png/PngEncoderCore.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -190,11 +190,11 @@ public void Encode<TPixel>(Image<TPixel> image, Stream stream, CancellationToken
190190

191191
if (image.Frames.Count > 1)
192192
{
193-
this.WriteAnimationControlChunk(stream, (uint)(image.Frames.Count - (pngMetadata.DefaultImageAnimated ? 0 : 1)), pngMetadata.RepeatCount);
193+
this.WriteAnimationControlChunk(stream, (uint)(image.Frames.Count - (pngMetadata.AnimateRootFrame ? 0 : 1)), pngMetadata.RepeatCount);
194194
}
195195

196196
// If the first frame isn't animated, write it as usual and skip it when writing animated frames
197-
if (!pngMetadata.DefaultImageAnimated || image.Frames.Count == 1)
197+
if (!pngMetadata.AnimateRootFrame || image.Frames.Count == 1)
198198
{
199199
FrameControl frameControl = new((uint)this.width, (uint)this.height);
200200
this.WriteDataChunks(frameControl, currentFrame.PixelBuffer.GetRegion(), quantized, stream, false);
@@ -209,7 +209,7 @@ public void Encode<TPixel>(Image<TPixel> image, Stream stream, CancellationToken
209209
PngDisposalMethod previousDisposal = frameMetadata.DisposalMethod;
210210
FrameControl frameControl = this.WriteFrameControlChunk(stream, frameMetadata, currentFrame.Bounds(), 0);
211211
uint sequenceNumber = 1;
212-
if (pngMetadata.DefaultImageAnimated)
212+
if (pngMetadata.AnimateRootFrame)
213213
{
214214
this.WriteDataChunks(frameControl, currentFrame.PixelBuffer.GetRegion(), quantized, stream, false);
215215
}

src/ImageSharp/Formats/Png/PngMetadata.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ private PngMetadata(PngMetadata other)
2929
this.InterlaceMethod = other.InterlaceMethod;
3030
this.TransparentColor = other.TransparentColor;
3131
this.RepeatCount = other.RepeatCount;
32-
this.DefaultImageAnimated = other.DefaultImageAnimated;
32+
this.AnimateRootFrame = other.AnimateRootFrame;
3333

3434
if (other.ColorTable?.Length > 0)
3535
{
@@ -85,9 +85,9 @@ private PngMetadata(PngMetadata other)
8585
public uint RepeatCount { get; set; } = 1;
8686

8787
/// <summary>
88-
/// Gets or sets a value indicating whether the default image is shown as part of the animated sequence
88+
/// Gets or sets a value indicating whether the root frame is shown as part of the animated sequence
8989
/// </summary>
90-
public bool DefaultImageAnimated { get; set; } = true;
90+
public bool AnimateRootFrame { get; set; } = true;
9191

9292
/// <inheritdoc/>
9393
public IDeepCloneable DeepClone() => new PngMetadata(this);

tests/ImageSharp.Tests/Formats/Png/PngEncoderTests.Chunks.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public void AcTL_CorrectlyWritten<TPixel>(TestImageProvider<TPixel> provider)
6868
{
6969
using Image<TPixel> image = provider.GetImage(PngDecoder.Instance);
7070
PngMetadata metadata = image.Metadata.GetPngMetadata();
71-
int correctFrameCount = image.Frames.Count - (metadata.DefaultImageAnimated ? 0 : 1);
71+
int correctFrameCount = image.Frames.Count - (metadata.AnimateRootFrame ? 0 : 1);
7272
using MemoryStream memStream = new();
7373
image.Save(memStream, PngEncoder);
7474
memStream.Position = 0;

tests/ImageSharp.Tests/Formats/Png/PngEncoderTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -470,7 +470,7 @@ public void Encode_APng<TPixel>(TestImageProvider<TPixel> provider)
470470
PngMetadata outputMetadata = output.Metadata.GetPngMetadata();
471471

472472
Assert.Equal(originalMetadata.RepeatCount, outputMetadata.RepeatCount);
473-
Assert.Equal(originalMetadata.DefaultImageAnimated, outputMetadata.DefaultImageAnimated);
473+
Assert.Equal(originalMetadata.AnimateRootFrame, outputMetadata.AnimateRootFrame);
474474

475475
for (int i = 0; i < image.Frames.Count; i++)
476476
{

tests/ImageSharp.Tests/Formats/Png/PngMetadataTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public void CloneIsDeep()
3333
Gamma = 2,
3434
TextData = new List<PngTextData> { new PngTextData("name", "value", "foo", "bar") },
3535
RepeatCount = 123,
36-
DefaultImageAnimated = false
36+
AnimateRootFrame = false
3737
};
3838

3939
PngMetadata clone = (PngMetadata)meta.DeepClone();
@@ -45,7 +45,7 @@ public void CloneIsDeep()
4545
Assert.False(meta.TextData.Equals(clone.TextData));
4646
Assert.True(meta.TextData.SequenceEqual(clone.TextData));
4747
Assert.True(meta.RepeatCount == clone.RepeatCount);
48-
Assert.True(meta.DefaultImageAnimated == clone.DefaultImageAnimated);
48+
Assert.True(meta.AnimateRootFrame == clone.AnimateRootFrame);
4949

5050
clone.BitDepth = PngBitDepth.Bit2;
5151
clone.ColorType = PngColorType.Palette;
@@ -153,7 +153,7 @@ public void Decode_IdentifiesDefaultFrameNotAnimated<TPixel>(TestImageProvider<T
153153
{
154154
using Image<TPixel> image = provider.GetImage(PngDecoder.Instance);
155155
PngMetadata meta = image.Metadata.GetFormatMetadata(PngFormat.Instance);
156-
Assert.False(meta.DefaultImageAnimated);
156+
Assert.False(meta.AnimateRootFrame);
157157
}
158158

159159
[Theory]
@@ -163,7 +163,7 @@ public void Decode_IdentifiesDefaultFrameAnimated<TPixel>(TestImageProvider<TPix
163163
{
164164
using Image<TPixel> image = provider.GetImage(PngDecoder.Instance);
165165
PngMetadata meta = image.Metadata.GetFormatMetadata(PngFormat.Instance);
166-
Assert.True(meta.DefaultImageAnimated);
166+
Assert.True(meta.AnimateRootFrame);
167167
}
168168

169169
[Theory]

0 commit comments

Comments
 (0)