Match other format configuration handling

Author: JimBobSquarePants

src/ImageSharp/Formats/Tga/TgaEncoderCore.cs

@@ -22,11 +22,6 @@ internal sealed class TgaEncoderCore : IImageEncoderInternals
     /// </summary>
     private readonly MemoryAllocator memoryAllocator;
 
-    /// <summary>
-    /// The global configuration.
-    /// </summary>
-    private Configuration? configuration;
-
     /// <summary>
     /// Reusable buffer for writing data.
     /// </summary>
@@ -67,7 +62,6 @@ public void Encode<TPixel>(Image<TPixel> image, Stream stream, CancellationToken
         Guard.NotNull(image, nameof(image));
         Guard.NotNull(stream, nameof(stream));
 
-        this.configuration = image.GetConfiguration();
         ImageMetadata metadata = image.Metadata;
         TgaMetadata tgaMetadata = metadata.GetTgaMetadata();
         this.bitsPerPixel ??= tgaMetadata.BitsPerPixel;
@@ -123,7 +117,7 @@ public void Encode<TPixel>(Image<TPixel> image, Stream stream, CancellationToken
         }
         else
         {
-            this.WriteImage(stream, image.Frames.RootFrame);
+            this.WriteImage(image.GetConfiguration(), stream, image.Frames.RootFrame);
         }
 
         stream.Flush();
@@ -133,30 +127,31 @@ public void Encode<TPixel>(Image<TPixel> image, Stream stream, CancellationToken
     /// Writes the pixel data to the binary stream.
     /// </summary>
     /// <typeparam name="TPixel">The pixel format.</typeparam>
+    /// <param name="configuration">The global configuration.</param>
     /// <param name="stream">The <see cref="Stream"/> to write to.</param>
     /// <param name="image">
     /// The <see cref="ImageFrame{TPixel}"/> containing pixel data.
     /// </param>
-    private void WriteImage<TPixel>(Stream stream, ImageFrame<TPixel> image)
+    private void WriteImage<TPixel>(Configuration configuration, Stream stream, ImageFrame<TPixel> image)
         where TPixel : unmanaged, IPixel<TPixel>
     {
         Buffer2D<TPixel> pixels = image.PixelBuffer;
         switch (this.bitsPerPixel)
         {
             case TgaBitsPerPixel.Pixel8:
-                this.Write8Bit(stream, pixels);
+                this.Write8Bit(configuration, stream, pixels);
                 break;
 
             case TgaBitsPerPixel.Pixel16:
-                this.Write16Bit(stream, pixels);
+                this.Write16Bit(configuration, stream, pixels);
                 break;
 
             case TgaBitsPerPixel.Pixel24:
-                this.Write24Bit(stream, pixels);
+                this.Write24Bit(configuration, stream, pixels);
                 break;
 
             case TgaBitsPerPixel.Pixel32:
-                this.Write32Bit(stream, pixels);
+                this.Write32Bit(configuration, stream, pixels);
                 break;
         }
     }
@@ -226,7 +221,7 @@ private void WritePixel<TPixel>(Stream stream, TPixel currentPixel, Rgba32 color
 
             case TgaBitsPerPixel.Pixel16:
                 Bgra5551 bgra5551 = new(color.ToVector4());
-                BinaryPrimitives.TryWriteInt16LittleEndian(this.buffer, (short)bgra5551.PackedValue);
+                BinaryPrimitives.WriteInt16LittleEndian(this.buffer, (short)bgra5551.PackedValue);
                 stream.WriteByte(this.buffer[0]);
                 stream.WriteByte(this.buffer[1]);
 
@@ -320,9 +315,10 @@ private IMemoryOwner<byte> AllocateRow(int width, int bytesPerPixel)
     /// Writes the 8bit pixels uncompressed to the stream.
     /// </summary>
     /// <typeparam name="TPixel">The pixel format.</typeparam>
+    /// <param name="configuration">The global configuration.</param>
     /// <param name="stream">The <see cref="Stream"/> to write to.</param>
     /// <param name="pixels">The <see cref="Buffer2D{TPixel}"/> containing pixel data.</param>
-    private void Write8Bit<TPixel>(Stream stream, Buffer2D<TPixel> pixels)
+    private void Write8Bit<TPixel>(Configuration configuration, Stream stream, Buffer2D<TPixel> pixels)
         where TPixel : unmanaged, IPixel<TPixel>
     {
         using IMemoryOwner<byte> row = this.AllocateRow(pixels.Width, 1);
@@ -332,7 +328,7 @@ private void Write8Bit<TPixel>(Stream stream, Buffer2D<TPixel> pixels)
         {
             Span<TPixel> pixelSpan = pixels.DangerousGetRowSpan(y);
             PixelOperations<TPixel>.Instance.ToL8Bytes(
-                this.configuration,
+                configuration,
                 pixelSpan,
                 rowSpan,
                 pixelSpan.Length);
@@ -344,9 +340,10 @@ private void Write8Bit<TPixel>(Stream stream, Buffer2D<TPixel> pixels)
     /// Writes the 16bit pixels uncompressed to the stream.
     /// </summary>
     /// <typeparam name="TPixel">The pixel format.</typeparam>
+    /// <param name="configuration">The global configuration.</param>
     /// <param name="stream">The <see cref="Stream"/> to write to.</param>
     /// <param name="pixels">The <see cref="Buffer2D{TPixel}"/> containing pixel data.</param>
-    private void Write16Bit<TPixel>(Stream stream, Buffer2D<TPixel> pixels)
+    private void Write16Bit<TPixel>(Configuration configuration, Stream stream, Buffer2D<TPixel> pixels)
         where TPixel : unmanaged, IPixel<TPixel>
     {
         using IMemoryOwner<byte> row = this.AllocateRow(pixels.Width, 2);
@@ -356,7 +353,7 @@ private void Write16Bit<TPixel>(Stream stream, Buffer2D<TPixel> pixels)
         {
             Span<TPixel> pixelSpan = pixels.DangerousGetRowSpan(y);
             PixelOperations<TPixel>.Instance.ToBgra5551Bytes(
-                this.configuration,
+                configuration,
                 pixelSpan,
                 rowSpan,
                 pixelSpan.Length);
@@ -368,9 +365,10 @@ private void Write16Bit<TPixel>(Stream stream, Buffer2D<TPixel> pixels)
     /// Writes the 24bit pixels uncompressed to the stream.
     /// </summary>
     /// <typeparam name="TPixel">The pixel format.</typeparam>
+    /// <param name="configuration">The global configuration.</param>
     /// <param name="stream">The <see cref="Stream"/> to write to.</param>
     /// <param name="pixels">The <see cref="Buffer2D{TPixel}"/> containing pixel data.</param>
-    private void Write24Bit<TPixel>(Stream stream, Buffer2D<TPixel> pixels)
+    private void Write24Bit<TPixel>(Configuration configuration, Stream stream, Buffer2D<TPixel> pixels)
         where TPixel : unmanaged, IPixel<TPixel>
     {
         using IMemoryOwner<byte> row = this.AllocateRow(pixels.Width, 3);
@@ -380,7 +378,7 @@ private void Write24Bit<TPixel>(Stream stream, Buffer2D<TPixel> pixels)
         {
             Span<TPixel> pixelSpan = pixels.DangerousGetRowSpan(y);
             PixelOperations<TPixel>.Instance.ToBgr24Bytes(
-                this.configuration,
+                configuration,
                 pixelSpan,
                 rowSpan,
                 pixelSpan.Length);
@@ -392,9 +390,10 @@ private void Write24Bit<TPixel>(Stream stream, Buffer2D<TPixel> pixels)
     /// Writes the 32bit pixels uncompressed to the stream.
     /// </summary>
     /// <typeparam name="TPixel">The pixel format.</typeparam>
+    /// <param name="configuration">The global configuration.</param>
     /// <param name="stream">The <see cref="Stream"/> to write to.</param>
     /// <param name="pixels">The <see cref="Buffer2D{TPixel}"/> containing pixel data.</param>
-    private void Write32Bit<TPixel>(Stream stream, Buffer2D<TPixel> pixels)
+    private void Write32Bit<TPixel>(Configuration configuration, Stream stream, Buffer2D<TPixel> pixels)
         where TPixel : unmanaged, IPixel<TPixel>
     {
         using IMemoryOwner<byte> row = this.AllocateRow(pixels.Width, 4);
@@ -404,7 +403,7 @@ private void Write32Bit<TPixel>(Stream stream, Buffer2D<TPixel> pixels)
         {
             Span<TPixel> pixelSpan = pixels.DangerousGetRowSpan(y);
             PixelOperations<TPixel>.Instance.ToBgra32Bytes(
-                this.configuration,
+                configuration,
                 pixelSpan,
                 rowSpan,
                 pixelSpan.Length);