Merge pull request #2386 from Ollie-Ave/main

JimBobSquarePants · web-flow · commit da5b556459b7 · 2023-03-06T22:55:32.000+10:00
ISSUE #2385 - Implementing try get pattern to TryFindFormatByFileExtension(string extension, [NotNullWhen(true)] out IImageFormat? format)
diff --git a/src/ImageSharp/Formats/ImageFormatManager.cs b/src/ImageSharp/Formats/ImageFormatManager.cs
@@ -102,9 +102,7 @@ public void AddImageFormat(IImageFormat format)
     /// <returns><see langword="true"/> if a match is found; otherwise, <see langword="false"/></returns>
     public bool TryFindFormatByFileExtension(string extension, [NotNullWhen(true)] out IImageFormat? format)
     {
-        Guard.NotNullOrWhiteSpace(extension, nameof(extension));
-
-        if (extension[0] == '.')
+        if (!string.IsNullOrWhiteSpace(extension) && extension[0] == '.')
         {
             extension = extension[1..];
         }

Original file line number	Diff line number	Diff line change
`@@ -102,9 +102,7 @@ public void AddImageFormat(IImageFormat format)`
`102`	`102`	`/// <returns><see langword="true"/> if a match is found; otherwise, <see langword="false"/></returns>`
`103`	`103`	`public bool TryFindFormatByFileExtension(string extension, [NotNullWhen(true)] out IImageFormat? format)`
`104`	`104`	`{`
`105`		`- Guard.NotNullOrWhiteSpace(extension, nameof(extension));`
`106`		`-`
`107`		`- if (extension[0] == '.')`
	`105`	`+ if (!string.IsNullOrWhiteSpace(extension) && extension[0] == '.')`
`108`	`106`	`{`
`109`	`107`	`extension = extension[1..];`
`110`	`108`	`}`