Add ARM hosted runners #3018
Draft
Add ARM hosted runners #3018
+28
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added macos-26 and ubuntu-2204 github runners which run on arm
We now use the tolerant Image Comparer for now.
This disables all tests which need libgdiplus for macs with arm. The hosted runners do not have libgdiplus installed
| public void BmpDecoder_CanDecode_8Bit<TPixel>(TestImageProvider<TPixel> provider) | ||
| where TPixel : unmanaged, IPixel<TPixel> | ||
| { | ||
| if (TestEnvironment.IsMacOS && TestEnvironment.IsArm64Process) |
Member
There was a problem hiding this comment.
I don’t think we should be disabling tests. We’ve been running on ARM for a while
Contributor
Author
There was a problem hiding this comment.
That's for missing libgdiplus
Member
There was a problem hiding this comment.
Isn't that because the build script restricts installation to ubuntu?
Contributor
Author
There was a problem hiding this comment.
Mac does not have apt. You must use homebrew. I can try it out. I haven't because I could not get mono-libgdiplus working on my machine 🙈
Member
There was a problem hiding this comment.
Ah yes, seems well supported though.
Contributor
Author
There was a problem hiding this comment.
seems supported. but it seems that it is not that easy. Tests are failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added macos-26 and ubuntu-2204 github-runners. Those run on ARM. With this this architecture can be tested on every run and not just on demand like before.