Skip to content

Commit 2bb0f85

Browse files
committed
ledger: disable several tests for NanoX
1 parent c0b268b commit 2bb0f85

File tree

1 file changed

+20
-0
lines changed

1 file changed

+20
-0
lines changed

test/test_device.py

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -586,12 +586,20 @@ def test_signtx(self):
586586
# https://github.com/bitcoin-core/HWI/pull/795#issuecomment-3112271927
587587
raise unittest.SkipTest("Coldcard sign test temporarily disabled")
588588

589+
if self.emulator.type == "ledger" and not self.emulator.legacy:
590+
# https://github.com/bitcoin-core/HWI/pull/795#issuecomment-3112271927
591+
raise unittest.SkipTest("Test temporarily disabled for NanoX")
592+
589593
for addrtypes, multisig_types, external, op_return in self.signtx_cases:
590594
with self.subTest(addrtypes=addrtypes, multisig_types=multisig_types, external=external, op_return=op_return):
591595
self._test_signtx(addrtypes, multisig_types, external, op_return)
592596

593597
# Make a huge transaction which might cause some problems with different interfaces
594598
def test_big_tx(self):
599+
if self.emulator.type == "ledger" and not self.emulator.legacy:
600+
# https://github.com/bitcoin-core/HWI/pull/795#issuecomment-3112271927
601+
raise unittest.SkipTest("Test temporarily disabled for NanoX")
602+
595603
# make a huge transaction
596604
keypool_desc = self.do_command(self.dev_args + ["getkeypool", "--account", "10", "--addr-type", "sh_wit", "0", "100"])
597605
import_result = self.wrpc.importdescriptors(keypool_desc)
@@ -622,6 +630,10 @@ def test_big_tx(self):
622630

623631
class TestDisplayAddress(DeviceTestCase):
624632
def test_display_address_path(self):
633+
if self.emulator.type == "ledger" and not self.emulator.legacy:
634+
# https://github.com/bitcoin-core/HWI/pull/795#issuecomment-3112271927
635+
raise unittest.SkipTest("Test temporarily disabled for NanoX")
636+
625637
result = self.do_command(self.dev_args + ['displayaddress', "--addr-type", "legacy", '--path', 'm/44h/1h/0h/0/0'])
626638
if self.emulator.supports_legacy:
627639
self.assertNotIn('error', result)
@@ -647,6 +659,10 @@ def test_display_address_bad_path(self):
647659
self.assertEqual(result['code'], -7)
648660

649661
def test_display_address_descriptor(self):
662+
if self.emulator.type == "ledger" and not self.emulator.legacy:
663+
# https://github.com/bitcoin-core/HWI/pull/795#issuecomment-3112271927
664+
raise unittest.SkipTest("Test temporarily disabled for NanoX")
665+
650666
account_xpub = self.do_command(self.dev_args + ['getxpub', 'm/84h/1h/0h'])['xpub']
651667
p2sh_segwit_account_xpub = self.do_command(self.dev_args + ['getxpub', 'm/49h/1h/0h'])['xpub']
652668
legacy_account_xpub = self.do_command(self.dev_args + ['getxpub', 'm/44h/1h/0h'])['xpub']
@@ -768,6 +784,10 @@ def _check_sign_msg(self, msg):
768784
self.assertTrue(self.rpc.verifymessage(addr, sig, msg))
769785

770786
def test_sign_msg(self):
787+
if self.emulator.type == "ledger" and not self.emulator.legacy:
788+
# https://github.com/bitcoin-core/HWI/pull/795#issuecomment-3112271927
789+
raise unittest.SkipTest("Test temporarily disabled for NanoX")
790+
771791
self._check_sign_msg("Message signing test")
772792
self._check_sign_msg("285") # Specific test case for Ledger shorter S
773793

0 commit comments

Comments
 (0)