Skip to content

Commit 32c662e

Browse files
committed
coldcard: disable test_signtx
``` ERROR: coldcard: test_signtx (test_device.TestSignTx.test_signtx) (addrtypes=['legacy'], multisig_types=['legacy'], external=True, op_return=False) ---------------------------------------------------------------------- Traceback (most recent call last): File "/__w/HWI/HWI/test/test_device.py", line 588, in test_signtx self._test_signtx(addrtypes, multisig_types, external, op_return) File "/__w/HWI/HWI/test/test_device.py", line 576, in _test_signtx self._generate_and_finalize(True, psbt) File "/__w/HWI/HWI/test/test_device.py", line 403, in _generate_and_finalize self.assertTrue(first_sign_res["signed"]) ~~~~~~~~~~~~~~^^^^^^^^^^ KeyError: 'signed' ```
1 parent b37adf4 commit 32c662e

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

test/test_device.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ def create(*args, **kwargs):
137137
return c
138138

139139
class DeviceTestCase(unittest.TestCase):
140-
def __init__(self, bitcoind, emulator=None, interface='library', methodName='runTest'):
140+
def __init__(self, bitcoind, emulator: DeviceEmulator = None, interface='library', methodName='runTest'):
141141
super(DeviceTestCase, self).__init__(methodName)
142142
self.bitcoind = bitcoind
143143
self.rpc = bitcoind.rpc
@@ -582,6 +582,9 @@ def _test_signtx(self, input_types, multisig_types, external, op_return: bool):
582582

583583
# Test wrapper to avoid mixed-inputs signing for Ledger
584584
def test_signtx(self):
585+
if self.emulator.type == "coldcard":
586+
# https://github.com/bitcoin-core/HWI/pull/795#issuecomment-3112271927
587+
raise unittest.SkipTest("Coldcard sign test temporarily disabled")
585588

586589
for addrtypes, multisig_types, external, op_return in self.signtx_cases:
587590
with self.subTest(addrtypes=addrtypes, multisig_types=multisig_types, external=external, op_return=op_return):

0 commit comments

Comments
 (0)