Apply suggestions from code review

Co-Authored-By: Ewan Noble <[email protected]>
Co-Authored-By: Dale Morson <[email protected]>
Co-Authored-By: jack-education <[email protected]>

Author: 4 people

Build-Task.ps1

@@ -154,7 +154,6 @@ try {
 
             switch ($Package.Type) {
                 'PSGallery' {
-
                     $PackageInstallDirectory = "$PackageTemp/$($Package.Name)"
 
                     $SaveModuleParameters = @{
@@ -177,7 +176,6 @@ try {
                     break
                 }
                 'Nuget' {
-
                     $PackageSources = @(Get-PackageSource | Where-Object { $_.Name -like "*nuget*" })
                     $PackageDestination = "$PackageTemp/$($Package.Name).$($Package.Version)"
 

tasks/EnvironmentConfiguration/task/ps_modules/Handlers/Handlers.psm1

@@ -7,7 +7,6 @@ Export-ModuleMember -Function @(
     'New-ConfigurationTableEntry'
 )
 
-
 $Script:EmojiDictionary = @{
     GreenCheck = [System.Text.Encoding]::UTF32.GetString(@(20, 39, 0, 0))
     StopWatch  = [System.Text.Encoding]::UTF32.GetString(@(241, 35, 0, 0))

tasks/EnvironmentConfiguration/task/ps_modules/Handlers/private/storage/Set-TableEntity.ps1

@@ -24,5 +24,4 @@ function Set-TableEntity {
     finally {
         Trace-VstsLeavingInvocation $MyInvocation
     }
-
 }

tasks/EnvironmentConfiguration/tests/New-ConfigurationEntity.unit.tests.ps1

@@ -29,7 +29,7 @@ InModuleScope "Handlers" {
                     Permissions = "Full"
                 },
                 @{
-                    Key1        = "key2"
+                    KeyName     = "key2"
                     Value       = "bW9jayBzdG9yYWdlIGFjY291bnQga2V5IG5vdGhpbmcgdG8gc2VlIGhlcmUgMg=="
                     Permissions = "Full"
                 }

tasks/EnvironmentConfiguration/tests/Test-Configuration.unit.tests.ps1

@@ -17,7 +17,7 @@ InModuleScope "Handlers" {
 
         Context "When the configuration passed matches the schema definition" {
 
-            It "Should validate succesfully and not throw an exception" {
+            It "Should validate successfully and not throw an exception" {
                 { Test-ConfigurationEntity -Configuration $ValidConfiguration -SchemaDefinitionPath $SchemaDefinition } | Should Not Throw
             }
         }