Migrate to proper unit test

This requires moving to a unit/ subdirectory to indicate that
we do not need to load MW when running these tests.

Additionally, instead of checking that we call various methods on
OutputPage when denying access, refactor denyAccess to a protected
method and mock it during testing, so that we can ensure denyAccess is
called without running any of its code. The code itself requires the
services container to be instantiated in order for wfMessage()->plain()
to work, which we cannot do during pure unit tests.

We should probably also add some integration tests to verify that
denyAccess() behaves as expected, in addition to tests that exercise
other aspects of the extension.

Author: skizzerz

includes/Hooks.php

@@ -75,7 +75,7 @@ public function onMediaWikiPerformAction(
 				|| $oldId > 0
 			)
 		) {
-			self::denyAccess( $output );
+			$this->denyAccess( $output );
 			return false;
 		}
 
@@ -99,7 +99,7 @@ public function onSpecialPageBeforeExecute( $special, $subPage ) {
 		$name = strtolower( $special->getName() );
 		if ( in_array( $name, [ 'recentchangeslinked', 'whatlinkshere' ], true ) ) {
 			$out = $special->getContext()->getOutput();
-			self::denyAccess( $out );
+			$this->denyAccess( $out );
 			return false;
 		}
 
@@ -112,9 +112,15 @@ public function onSpecialPageBeforeExecute( $special, $subPage ) {
 	 * @param OutputPage $output
 	 * @return void
 	 */
-	private static function denyAccess( OutputPage $output ): void {
+	protected function denyAccess( OutputPage $output ): void {
 		$output->setStatusCode( 403 );
-		$output->setPageTitle( wfMessage( 'crawlerprotection-accessdenied-title' )->text() );
-		$output->addWikiTextAsInterface( wfMessage( 'crawlerprotection-accessdenied-text' )->text() );
+		$output->addWikiTextAsInterface( wfMessage( 'crawlerprotection-accessdenied-text' )->plain() );
+
+		if ( version_compare( MW_VERSION, '1.41', '<' ) ) {
+			$output->setPageTitle( wfMessage( 'crawlerprotection-accessdenied-title' ) );
+		} else {
+			// @phan-suppress-next-line PhanUndeclaredMethod Exists in 1.41+
+			$output->setPageTitleMsg( wfMessage( 'crawlerprotection-accessdenied-title' ) );
+		}
 	}
 }

tests/phpunit/HooksTest.php tests/phpunit/unit/HooksTest.phptests/phpunit/HooksTest.php renamed to tests/phpunit/unit/HooksTest.php

@@ -58,9 +58,6 @@ public static function setUpBeforeClass(): void {
 	 */
 	public function testRevisionTypeBlocksAnonymous() {
 		$output = $this->createMock( self::$outputPageClassName );
-		$output->expects( $this->once() )->method( 'setPageTitle' );
-		$output->expects( $this->once() )->method( 'addWikiTextAsInterface' );
-		$output->expects( $this->once() )->method( 'setStatusCode' )->with( 403 );
 
 		$request = $this->createMock( self::$webRequestClassName );
 		$request->method( 'getVal' )->willReturnMap( [
@@ -74,7 +71,11 @@ public function testRevisionTypeBlocksAnonymous() {
 		$title = $this->createMock( self::$titleClassName );
 		$wiki = $this->createMock( self::$actionEntryPointClassName );
 
-		$runner = new Hooks();
+		$runner = $this->getMockBuilder( Hooks::class )
+			->onlyMethods( [ 'denyAccess' ] )
+			->getMock();
+		$runner->expects( $this->once() )->method( 'denyAccess' );
+
 		$result = $runner->onMediaWikiPerformAction( $output, $article, $title, $user, $request, $wiki );
 		$this->assertFalse( $result );
 	}
@@ -97,7 +98,11 @@ public function testRevisionTypeAllowsLoggedIn() {
 		$title = $this->createMock( self::$titleClassName );
 		$wiki = $this->createMock( self::$actionEntryPointClassName );
 
-		$runner = new Hooks();
+		$runner = $this->getMockBuilder( Hooks::class )
+			->onlyMethods( [ 'denyAccess' ] )
+			->getMock();
+		$runner->expects( $this->never() )->method( 'denyAccess' );
+
 		$result = $runner->onMediaWikiPerformAction( $output, $article, $title, $user, $request, $wiki );
 		$this->assertTrue( $result );
 	}
@@ -120,7 +125,11 @@ public function testNonRevisionTypeAlwaysAllowed() {
 		$title = $this->createMock( self::$titleClassName );
 		$wiki = $this->createMock( self::$actionEntryPointClassName );
 
-		$runner = new Hooks();
+		$runner = $this->getMockBuilder( Hooks::class )
+			->onlyMethods( [ 'denyAccess' ] )
+			->getMock();
+		$runner->expects( $this->never() )->method( 'denyAccess' );
+
 		$result = $runner->onMediaWikiPerformAction( $output, $article, $title, $user, $request, $wiki );
 		$this->assertTrue( $result );
 	}