Skip to content

Commit 4b63886

Browse files
committed
address feedback
1 parent 2bc649b commit 4b63886

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

tests/installation/playwright-cli-install-should-work.spec.ts

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -99,15 +99,14 @@ test('install command should work with mirror that uses chunked encoding', async
9999
}
100100
});
101101
await new Promise<void>(resolve => server.listen(0, resolve));
102-
await test.step('playwright install chromium', async () => {
103-
const result = await exec('npx playwright install chromium', {
104-
env: {
105-
PLAYWRIGHT_DOWNLOAD_HOST: `http://localhost:${(server.address() as any).port}`,
106-
}
107-
});
108-
expect(result).toHaveLoggedSoftwareDownload(['chromium', 'chromium-headless-shell', 'ffmpeg', ...extraInstalledSoftware]);
109-
await checkInstalledSoftwareOnDisk(['chromium', 'chromium-headless-shell', 'ffmpeg', ...extraInstalledSoftware]);
102+
const result = await exec('npx playwright install chromium', {
103+
env: {
104+
PLAYWRIGHT_DOWNLOAD_HOST: `http://localhost:${(server.address() as any).port}`,
105+
}
110106
});
107+
expect(result).toHaveLoggedSoftwareDownload(['chromium', 'chromium-headless-shell', 'ffmpeg', ...extraInstalledSoftware]);
108+
await checkInstalledSoftwareOnDisk(['chromium', 'chromium-headless-shell', 'ffmpeg', ...extraInstalledSoftware]);
109+
server.close();
111110
});
112111

113112
test('install command should ignore HTTP_PROXY', { annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/36412' } }, async ({ exec, checkInstalledSoftwareOnDisk }) => {

0 commit comments

Comments
 (0)