Fix overzealous literal type spec. parsing (#8027)

fix overzealous parsing

Author: sovdeeth

src/main/java/ch/njol/skript/lang/SkriptParser.java

@@ -680,7 +680,11 @@ private static <T extends SyntaxElement> boolean checkExperimentalSyntax(T eleme
 				if (classInfoMatcher.matches()) {
 					String literalString = classInfoMatcher.group("literal");
 					String unparsedClassInfo = Noun.stripDefiniteArticle(classInfoMatcher.group("classinfo"));
-					return parseSpecifiedLiteral(literalString, unparsedClassInfo, log, types);
+					Expression<?> result = parseSpecifiedLiteral(literalString, unparsedClassInfo, types);
+					if (result != null) {
+						log.printLog();
+						return result;
+					}
 				}
 			}
 			if (exprInfo.classes.length == 1 && exprInfo.classes[0].getC() == Object.class) {
@@ -752,38 +756,31 @@ private static <T extends SyntaxElement> boolean checkExperimentalSyntax(T eleme
 	 * </p>
 	 * @param literalString A {@link String} representing a literal
 	 * @param unparsedClassInfo A {@link String} representing a class info
-	 * @param log The current {@link ParseLogHandler} for containing errors
 	 * @param types An {@link Array} of the acceptable {@link Class}es
 	 * @return {@link SimpleLiteral} or {@code null} if any checks fail
 	 */
 	private @Nullable Expression<?> parseSpecifiedLiteral(
 		String literalString,
 		String unparsedClassInfo,
-		ParseLogHandler log,
 		Class<?> ... types
 	) {
 		ClassInfo<?> classInfo = Classes.parse(unparsedClassInfo, ClassInfo.class, context);
 		if (classInfo == null) {
-			log.printError();
+			Skript.error("A " + unparsedClassInfo  + " is not a valid type.");
 			return null;
 		}
 		Parser<?> classInfoParser = classInfo.getParser();
 		if (classInfoParser == null || !classInfoParser.canParse(context)) {
 			Skript.error("A " + unparsedClassInfo  + " cannot be parsed.");
-			log.printError();
 			return null;
 		}
 		if (!checkAcceptedType(classInfo.getC(), types)) {
 			Skript.error(expr + " " + Language.get("is") + " " + notOfType(types));
-			log.printError();
 			return null;
 		}
 		Object parsedObject = classInfoParser.parse(literalString, context);
-		if (parsedObject != null) {
-			log.printLog();
+		if (parsedObject != null)
 			return new SimpleLiteral<>(parsedObject, false, new UnparsedLiteral(literalString));
-		}
-		log.printError();
 		return null;
 	}
 

src/test/skript/tests/regressions/7861-overzealous literal type specification.sk

@@ -0,0 +1,8 @@
+test "literal specification breaks command arguments":
+	execute console command "littypecmd a (b)"
+	assert {littypecmd} is 1 with "Literal type specification broke command arguments"
+
+command /littypecmd <text>:
+	trigger:
+		if arg 1 is "a (b)":
+			set {littypecmd} to 1