Update ExprGameRule (#7943)

Author: erenkarakal

src/main/java/ch/njol/skript/expressions/ExprGameRule.java

@@ -1,5 +1,7 @@
 package ch.njol.skript.expressions;
 
+import ch.njol.skript.registrations.Classes;
+import ch.njol.skript.util.Utils;
 import org.bukkit.GameRule;
 import org.bukkit.World;
 import org.bukkit.event.Event;
@@ -10,82 +12,95 @@
 import ch.njol.skript.doc.Description;
 import ch.njol.skript.doc.Examples;
 import ch.njol.skript.doc.Name;
-import ch.njol.skript.doc.RequiredPlugins;
 import ch.njol.skript.doc.Since;
 import ch.njol.skript.lang.Expression;
 import ch.njol.skript.lang.ExpressionType;
 import ch.njol.skript.lang.SkriptParser.ParseResult;
 import ch.njol.skript.lang.util.SimpleExpression;
 import ch.njol.skript.util.GameruleValue;
 import ch.njol.util.Kleenean;
-import ch.njol.util.coll.CollectionUtils;
 
 @Name("Gamerule Value")
 @Description("The gamerule value of a world.")
 @Examples({"set the gamerule commandBlockOutput of world \"world\" to false"})
 @Since("2.5")
-@RequiredPlugins("Minecraft 1.13+")
 public class ExprGameRule extends SimpleExpression<GameruleValue> {
 
 	static {
-		if (Skript.classExists("org.bukkit.GameRule")) {
-			Skript.registerExpression(ExprGameRule.class, GameruleValue.class, ExpressionType.COMBINED,
-				"[the] gamerule %gamerule% of %worlds%");
-		}
+		Skript.registerExpression(ExprGameRule.class, GameruleValue.class, ExpressionType.COMBINED, "[the] gamerule %gamerule% of %worlds%");
 	}
-	
-	@SuppressWarnings("null")
-	private Expression<GameRule> gamerule;
-	@SuppressWarnings("null")
-	private Expression<World> world;
+
+	private Expression<GameRule<?>> gamerule;
+	private Expression<World> worlds;
 
 	@Override
 	public boolean init(Expression<?>[] exprs, int matchedPattern, Kleenean isDelayed, ParseResult parseResult) {
-		gamerule = (Expression<GameRule>) exprs[0];
-		world = (Expression<World>) exprs[1];
+		// noinspection unchecked
+		gamerule = (Expression<GameRule<?>>) exprs[0];
+		// noinspection unchecked
+		worlds = (Expression<World>) exprs[1];
 		return true;
 	}
-	
+
 	@Override
-	@Nullable
-	public Class<?>[] acceptChange(final ChangeMode mode) {
-		if (mode == ChangeMode.SET) 
-            return CollectionUtils.array(Boolean.class, Number.class);
-		return null;
+	protected GameruleValue<?> @Nullable [] get(Event event) {
+		GameRule<?> gamerule = this.gamerule.getSingle(event);
+		if (gamerule == null) {
+			return null;
+		}
+
+		World[] worlds = this.worlds.getArray(event);
+		GameruleValue<?>[] gameruleValues = new GameruleValue[worlds.length];
+
+		for (int i = 0; i < worlds.length; i++) {
+			Object gameruleValue = worlds[i].getGameRuleValue(gamerule);
+			assert gameruleValue != null;
+			gameruleValues[i] = new GameruleValue<>(gameruleValue);
+		}
+
+		return gameruleValues;
 	}
-	
+
 	@Override
-	public void change(final Event e, final @Nullable Object[] delta, final ChangeMode mode) {
-		assert delta != null;
+	public Class<?> @Nullable [] acceptChange(ChangeMode mode) {
 		if (mode == ChangeMode.SET) {
-			GameRule bukkitGamerule = gamerule.getSingle(e);
-			if (bukkitGamerule == null) 
-                return;
-			for (World gameruleWorld : world.getArray(e))
-                gameruleWorld.setGameRule(bukkitGamerule, delta[0]);
+			return new Class[]{Boolean.class, Integer.class};
 		}
+		return null;
 	}
-		
-	@Nullable
+
 	@Override
-	protected GameruleValue[] get(Event e) {
-		GameRule<?> bukkitGamerule = gamerule.getSingle(e);
-		if (bukkitGamerule == null) 
-            return null;
-		World[] gameruleWorlds = world.getArray(e);
-		GameruleValue[] gameruleValues = new GameruleValue[gameruleWorlds.length];
-		int index = 0;
-		for (World gameruleWorld : gameruleWorlds) {
-			Object gameruleValue = gameruleWorld.getGameRuleValue(bukkitGamerule);
-			assert gameruleValue != null;
-			gameruleValues[index++] = new GameruleValue<>(gameruleValue);
+	public void change(Event event, Object @Nullable [] delta, ChangeMode mode) {
+		if (mode != ChangeMode.SET) {
+			return;
+		}
+
+		GameRule gamerule = this.gamerule.getSingle(event);
+		if (gamerule == null) {
+			return;
+		}
+
+		assert delta != null;
+		Object value = delta[0];
+		if (!gamerule.getType().isAssignableFrom(value.getClass())) {
+			String currentClassName = Classes.toString(Classes.getSuperClassInfo(value.getClass()));
+			currentClassName = Utils.a(currentClassName);
+
+			String targetClassName = Classes.toString(Classes.getSuperClassInfo(gamerule.getType()));
+			targetClassName = Utils.a(targetClassName);
+
+			error("The " + gamerule.getName() + " gamerule can only be set to " + targetClassName + ", not " + currentClassName + ".");
+			return;
+		}
+
+		for (World gameruleWorld : worlds.getArray(event)) {
+			gameruleWorld.setGameRule(gamerule, value);
 		}
-		return gameruleValues;
 	}
-	
+
 	@Override
 	public boolean isSingle() {
-		return false;
+		return worlds.isSingle();
 	}
 
 	@Override
@@ -94,7 +109,8 @@ public Class<? extends GameruleValue> getReturnType() {
 	}
 
 	@Override
-	public String toString(@Nullable Event e, boolean debug) {
-		return "the gamerule value of " + gamerule.toString(e, debug) + " for world " + world.toString(e, debug);
+	public String toString(@Nullable Event event, boolean debug) {
+		return "the gamerule " + gamerule.toString(event, debug) + " of " + worlds.toString(event, debug);
 	}
+
 }