Skip to content

Commit 90ac359

Browse files
author
code
authored
remove senseless dynamic config to simplify code base (#131)
1 parent 9b7e772 commit 90ac359

File tree

10 files changed

+6
-512
lines changed

10 files changed

+6
-512
lines changed

.github/workflows/main.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,12 @@ jobs:
4040
- name: Install cmake dependencies and run cmake compile
4141
run: |
4242
sudo apt update
43-
sudo apt -y install cmake
43+
sudo apt -y install cmake
4444
sudo git clone -b v9.1.0 https://github.com/apache/skywalking-data-collect-protocol.git ./3rdparty/skywalking-data-collect-protocol
4545
sudo git clone -b v1.46.6 https://github.com/grpc/grpc.git --recursive
46-
sudo cmake -S ./grpc -B ./grpc/build
46+
sudo cmake -S ./grpc -B ./grpc/build
4747
sudo cmake --build ./grpc/build --parallel 8 --target install
48-
sudo cmake -S . -B ./build
48+
sudo cmake -S . -B ./build
4949
sudo cmake --build ./build
5050
- name: Install lcov and genhtml and link llvm
5151
run: |
@@ -70,7 +70,7 @@ jobs:
7070
- uses: actions/checkout@v3
7171
- name: Prepare service container
7272
run: |
73-
docker-compose -f test/e2e/docker/docker-compose.e2e.yml up -d
73+
docker compose -f test/e2e/docker/docker-compose.e2e.yml up -d
7474
- name: Run e2e
7575
run: |
7676
pip3 install --upgrade pip
@@ -84,7 +84,7 @@ jobs:
8484
- uses: actions/checkout@v3
8585
- name: Prepare service container
8686
run: |
87-
docker-compose -f test/e2e/docker/docker-compose.e2e-python.yml up -d
87+
docker compose -f test/e2e/docker/docker-compose.e2e-python.yml up -d
8888
- name: Run e2e
8989
run: |
9090
pip3 install --upgrade pip

source/BUILD

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,12 @@ load("@rules_cc//cc:defs.bzl", "cc_library")
33
cc_library(
44
name = "cpp2sky_lib",
55
srcs = [
6-
"cds_impl.cc",
7-
"dynamic_config.cc",
86
"grpc_async_client_impl.cc",
97
"propagation_impl.cc",
108
"tracer_impl.cc",
119
"tracing_context_impl.cc",
1210
],
1311
hdrs = [
14-
"cds_impl.h",
15-
"dynamic_config.h",
1612
"grpc_async_client_impl.h",
1713
"propagation_impl.h",
1814
"tracer_impl.h",

source/cds_impl.cc

Lines changed: 0 additions & 86 deletions
This file was deleted.

source/cds_impl.h

Lines changed: 0 additions & 103 deletions
This file was deleted.

source/dynamic_config.cc

Lines changed: 0 additions & 93 deletions
This file was deleted.

source/dynamic_config.h

Lines changed: 0 additions & 45 deletions
This file was deleted.

0 commit comments

Comments
 (0)