Skip to content

Commit 9845009

Browse files
committed
[NOJIRA] refactor to address lint issues, replace LocalContext
1 parent bf3f8de commit 9845009

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

app/src/main/java/net/skyscanner/backpack/demo/compose/ChipGroupStory.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ fun SingleSelectChipGroupStoryWrap(modifier: Modifier = Modifier) =
8686
@ChipGroupComponent
8787
@ComposeStory("Multi Select Rail")
8888
fun MultiSelectChipGroupStoryRail(modifier: Modifier = Modifier) {
89-
val context = LocalContext.current
89+
val notificationText = stringResource(R.string.sticky_chip_action)
9090
val floatingNotification = LocalFloatingNotification.current
9191
val scope = rememberCoroutineScope()
9292
ChipGroupDemo(
@@ -100,7 +100,7 @@ fun MultiSelectChipGroupStoryRail(modifier: Modifier = Modifier) {
100100
icon = BpkIcon.Filter,
101101
) {
102102
scope.launch {
103-
floatingNotification.show(context.getString(R.string.sticky_chip_action))
103+
floatingNotification.show(notificationText)
104104
}
105105
},
106106
),

app/src/main/java/net/skyscanner/backpack/demo/compose/RatingStory.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import androidx.compose.foundation.rememberScrollState
2626
import androidx.compose.foundation.verticalScroll
2727
import androidx.compose.runtime.Composable
2828
import androidx.compose.ui.Modifier
29-
import androidx.compose.ui.platform.LocalContext
3029
import androidx.compose.ui.res.stringResource
3130
import androidx.compose.ui.tooling.preview.Preview
3231
import net.skyscanner.backpack.compose.rating.BpkRating
@@ -191,11 +190,10 @@ internal fun BpkRatingLargeCustomContentNoSubtitleSample(modifier: Modifier = Mo
191190
private fun CustomContent(
192191
modifier: Modifier = Modifier,
193192
) {
194-
val context = LocalContext.current
195193
BpkStarRating(
196194
rating = RatingValue,
197195
contentDescription = { _, max ->
198-
context.getString(R.string.star_rating_accessibility_status, RatingValue, max)
196+
stringResource(R.string.star_rating_accessibility_status, RatingValue, max)
199197
},
200198
modifier = modifier,
201199
)

0 commit comments

Comments
 (0)